Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow more fields at root of CRD schema if status is enabled #65357
Currently, we allow only
We can also include some other fields, even though sometimes they might not make sense (but they don't harm).
The main idea is that when validation schema for status is extracted as
To be clear, we have three sets of now valid fields at the root:
I have no strong feelings about this, but tend to go forward with the PR.
For validation of the status subresource, we only validate the "status part" of the object (as opposed to validating the whole object). To do this, we extract the schema for status validation using
Since we extract the schema for status validation using
Looking forward to this landing! Marshalling of
Can this be a cherrypick candidate for 1.11?
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
Jul 3, 2018
17 checks passed
When the status subresource is enabled, the current behaviour right now (for 1.11.0) is to allow only
If the status subresource is not enabled, some other fields like
So if someone enables the status subresource, their CRDs will now be invalid if it contained
Note: the fields that this PR allows are "harmless" in the sense that they don't add any more functionality. They just make sure that if those fields in the CRD existed initially before enabling the status subresource, the CRD does not become invalid.