Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kubectl delete hack that handles DaemonSet deletion #65380

Merged
merged 1 commit into from Jun 30, 2018

Conversation

@janetkuo
Copy link
Member

janetkuo commented Jun 22, 2018

What this PR does / why we need it: follow up #64847

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Special notes for your reviewer:
/cc @liggitt @soltysh

Release note:

NONE
@adohe

This comment has been minimized.

Copy link
Member

adohe commented Jun 26, 2018

@janetkuo overall lgtm. please help fix conflict issue

@janetkuo

This comment has been minimized.

Copy link
Member Author

janetkuo commented Jun 28, 2018

/test pull-kubernetes-e2e-gce

@adohe

This comment has been minimized.

Copy link
Member

adohe commented Jun 29, 2018

/assign @adohe

@adohe

This comment has been minimized.

Copy link
Member

adohe commented Jun 29, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 29, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jun 29, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adohe, janetkuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jun 29, 2018

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@adohe @janetkuo

Pull Request Labels
  • sig/cli: Pull Request will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/cleanup: Adding tests, refactoring, fixing old bugs.
Help
@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jun 30, 2018

Automatic merge from submit-queue (batch tested with PRs 65518, 65624, 65380, 65390, 65586). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 1c2b2de into kubernetes:master Jun 30, 2018

17 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation janetkuo authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@jimangel

This comment has been minimized.

Copy link
Member

jimangel commented Aug 17, 2018

@janetkuo does this PR need docs for the 1.12 release?

@janetkuo

This comment has been minimized.

Copy link
Member Author

janetkuo commented Aug 24, 2018

@jimangel no, this doesn't need docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.