Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scheduler config decoding #65424

Merged
merged 1 commit into from Jun 25, 2018

Conversation

@liggitt
Copy link
Member

commented Jun 25, 2018

Fixes #65413

Implements a custom unmarshaler for a single scheduler config type which did not correctly specify JSON tags until #65414 is resolved

Adds missing compatibility tests for scheduler extenders back to 1.7

Fixes incompatibility with custom scheduler extender configurations specifying `bindVerb`
@resouer
Copy link
Member

left a comment

/lgtm

Thanks for including newly added fields in 1.10 1.11 releases.

@nikhita

This comment has been minimized.

Copy link
Member

commented Jun 25, 2018

/retest

@nikhita

This comment has been minimized.

Copy link
Member

commented Jun 25, 2018

This should be for the 1.12 milestone, right?

@nikhita

This comment has been minimized.

Copy link
Member

commented Jun 25, 2018

/assign @bsalamat
for approval

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2018

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@bsalamat @liggitt @resouer

Pull Request Labels
  • sig/scheduling: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help
@k82cn

This comment has been minimized.

Copy link
Member

commented Jun 25, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, liggitt, resouer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nikhita

This comment has been minimized.

Copy link
Member

commented Jun 25, 2018

@k82cn Can you approve the cherry-picks as well? :)

The list of cherry-picks is here: #65413 (comment).

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit a13fe4d into kubernetes:master Jun 25, 2018

16 of 17 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce-100-performance
Details
cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
k8s-github-robot pushed a commit that referenced this pull request Jun 25, 2018
Kubernetes Submit Queue
Merge pull request #65416 from liggitt/automated-cherry-pick-of-#6541…
…5-upstream-release-1.11

Automatic merge from submit-queue.

Automated cherry pick of #65424: Fix scheduler config decoding

Cherry pick of #65424 on release-1.11.

#65424: Fix scheduler config decoding
k8s-github-robot pushed a commit that referenced this pull request Jun 25, 2018
Kubernetes Submit Queue
Merge pull request #65419 from liggitt/automated-cherry-pick-of-#6541…
…5-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #65424: Fix scheduler config decoding

Cherry pick of #65424 on release-1.8.

#65424: Fix scheduler config decoding
k8s-github-robot pushed a commit that referenced this pull request Jun 26, 2018
Kubernetes Submit Queue
Merge pull request #65417 from liggitt/automated-cherry-pick-of-#6541…
…5-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #65424: Fix scheduler config decoding

Cherry pick of #65424 on release-1.10.

#65424: Fix scheduler config decoding
k8s-github-robot pushed a commit that referenced this pull request Jun 26, 2018
Kubernetes Submit Queue
Merge pull request #65418 from liggitt/automated-cherry-pick-of-#6541…
…5-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #65424: Fix scheduler config decoding

Cherry pick of #65424 on release-1.9.

#65424: Fix scheduler config decoding

@liggitt liggitt deleted the liggitt:scheduler-config branch Jun 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.