Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/e2e_node/system/types_unix: support ZFS #65635

Merged
merged 1 commit into from Jul 2, 2018

Conversation

@neolit123
Copy link
Member

neolit123 commented Jun 29, 2018

What this PR does / why we need it:

Docker validation tests in the case of ZFS used as the graph driver
fail due to "zfs" not being present in the default Docker specification.

Add "zfs" in the GraphDriver slice.

kubeadm relies on the DockerValidator and pre-flight checks would fail if the user is using ZFS.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Updates kubernetes/kubeadm#930

Special notes for your reviewer:
NONE

/cc @kubernetes/sig-node-pr-reviews
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews
/cc @kvaps (reported by)
/area node-e2e
/area kubeadm

Release note:

Unix: support ZFS as a valid graph driver for Docker
test/e2e_node/system/types_unix: support ZFS
Docker validation tests in the case of ZFS used as the graph driver
fail due to "zfs" not being present in the default Docker specification.

Add "zfs" in the GraphDriver slice.
@neolit123

This comment has been minimized.

Copy link
Member Author

neolit123 commented Jun 29, 2018

/test pull-kubernetes-e2e-gce

@luxas

luxas approved these changes Jun 29, 2018

Copy link
Member

luxas left a comment

/lgtm
Needs approval by @kubernetes/sig-node-pr-reviews

@luxas

This comment has been minimized.

Copy link
Member

luxas commented Jun 29, 2018

/kind bug

@@ -63,7 +63,7 @@ var DefaultSysSpec = SysSpec{
RuntimeSpec: RuntimeSpec{
DockerSpec: &DockerSpec{
Version: []string{`1\.1[1-3]\..*`, `17\.03\..*`}, // Requires [1.11, 17.03]
GraphDriver: []string{"aufs", "overlay", "overlay2", "devicemapper"},
GraphDriver: []string{"aufs", "overlay", "overlay2", "devicemapper", "zfs"},

This comment has been minimized.

@ConnorDoyle

ConnorDoyle Jun 30, 2018

Member

In general this seems fine. My only question is that since this system spec is also used in e2e_node_suite_test.go, whether this implies any particular level of support for docker + zfs.

cc @timothysc @derekwaynecarr

This comment has been minimized.

@neolit123

neolit123 Jun 30, 2018

Author Member

my only confirmation that people are actually using ZFS + Docker + k8s is the issue report that triggered this PR:
kubernetes/kubeadm#930 (comment)

and also this blog post:
https://hackernoon.com/starting-small-with-kubernetes-and-kubeadm-500-containers-6c76454e6e12

so in a way people are already using it, but not sure how a particular level of support can be defined for a Docker graph driver.

@dashpole

This comment has been minimized.

Copy link
Contributor

dashpole commented Jul 2, 2018

While we don't have any e2e testing to validate that ZFS works each release, there are definitely people using it. There is a group of contributors that submit bug-fixes for ZFS to cAdvisor, so I expect zfs to continue to function in future releases.

@ConnorDoyle

This comment has been minimized.

Copy link
Member

ConnorDoyle commented Jul 2, 2018

The only supported Docker storage driver missing here is vfs which as IIUC isn't desirable in most production settings. If anyone needs that driver whitelisted in the default spec they can create a new issue.

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jul 2, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorDoyle, luxas, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neolit123

This comment has been minimized.

Copy link
Member Author

neolit123 commented Jul 2, 2018

@ConnorDoyle @luxas
do you think i should cherry-pick this for older releases and which ones?

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 2, 2018

Automatic merge from submit-queue (batch tested with PRs 65348, 65599, 65635, 65688, 65691). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 5d87a70 into kubernetes:master Jul 2, 2018

17 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation neolit123 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@dims dims referenced this pull request Jul 7, 2018

Closed

ZFS isn't supported #930

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.