Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/e2e_node/system/types_unix: support ZFS #65635

Merged
merged 1 commit into from Jul 2, 2018
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.
+1 −1
Diff settings

Always

Just for now

@@ -63,7 +63,7 @@ var DefaultSysSpec = SysSpec{
RuntimeSpec: RuntimeSpec{
DockerSpec: &DockerSpec{
Version: []string{`1\.1[1-3]\..*`, `17\.03\..*`}, // Requires [1.11, 17.03]
GraphDriver: []string{"aufs", "overlay", "overlay2", "devicemapper"},
GraphDriver: []string{"aufs", "overlay", "overlay2", "devicemapper", "zfs"},

This comment has been minimized.

Copy link
@ConnorDoyle

ConnorDoyle Jun 30, 2018

Member

In general this seems fine. My only question is that since this system spec is also used in e2e_node_suite_test.go, whether this implies any particular level of support for docker + zfs.

cc @timothysc @derekwaynecarr

This comment has been minimized.

Copy link
@neolit123

neolit123 Jun 30, 2018

Author Member

my only confirmation that people are actually using ZFS + Docker + k8s is the issue report that triggered this PR:
kubernetes/kubeadm#930 (comment)

and also this blog post:
https://hackernoon.com/starting-small-with-kubernetes-and-kubeadm-500-containers-6c76454e6e12

so in a way people are already using it, but not sure how a particular level of support can be defined for a Docker graph driver.

},
},
}
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.