Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload systemd config files before starting kubelet. #65702

Merged
merged 1 commit into from Jul 3, 2018

Conversation

Projects
None yet
5 participants
@mborsz
Copy link
Member

mborsz commented Jul 2, 2018

In some environments, the os image comes with preloaded kubelet.service,
so we need to reload systemctl configs to make changes effective.

What this PR does / why we need it:
Some OS images already contains kubelet.service with preloaded kubelet in some random version. After doing changes to kubelet.service we need to call 'systemctl daemon-reload' to make changes effective.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Reload systemd config files before starting kubelet.

@k8s-ci-robot k8s-ci-robot requested review from MaciekPytel and vishh Jul 2, 2018

@mborsz mborsz changed the title Reload systemctl config files before starting kubelet. Reload systemd config files before starting kubelet. Jul 2, 2018

Reload systemd config files before starting kubelet.
In some environments, the os image comes with preloaded kubelet.service,
so we need to reload systemctl configs to make changes effective.

@mborsz mborsz force-pushed the mborsz:reload branch from 613c036 to b309c58 Jul 2, 2018

@mborsz

This comment has been minimized.

Copy link
Member Author

mborsz commented Jul 2, 2018

/assign @wojtek-t

@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Jul 2, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 2, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jul 2, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mborsz, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mborsz

This comment has been minimized.

Copy link
Member Author

mborsz commented Jul 2, 2018

/retest

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 3, 2018

Automatic merge from submit-queue (batch tested with PRs 65094, 65533, 63522, 65694, 65702). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit a3d30dc into kubernetes:master Jul 3, 2018

17 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation mborsz authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

k8s-github-robot pushed a commit that referenced this pull request Jul 4, 2018

Kubernetes Submit Queue
Merge pull request #65748 from mborsz/automated-cherry-pick-of-#65702…
…-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #65702: Reload systemd config files before starting kubelet.

Cherry pick of #65702 on release-1.10.

#65702: Reload systemd config files before starting kubelet.

k8s-github-robot pushed a commit that referenced this pull request Jul 11, 2018

Kubernetes Submit Queue
Merge pull request #65747 from mborsz/automated-cherry-pick-of-#65702…
…-upstream-release-1.11

Automatic merge from submit-queue.

Automated cherry pick of #65702: Reload systemd config files before starting kubelet.

Cherry pick of #65702 on release-1.11.

#65702: 
```
Reload systemd config files before starting kubelet.
```

k8s-github-robot pushed a commit that referenced this pull request Jul 11, 2018

Kubernetes Submit Queue
Merge pull request #65749 from mborsz/automated-cherry-pick-of-#65702…
…-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #65702: Reload systemd config files before starting kubelet.

Cherry pick of #65702 on release-1.9.

#65702: Reload systemd config files before starting kubelet.

```release-note
Reload systemd config files before starting kubelet.
```
@marpaia

This comment has been minimized.

Copy link
Member

marpaia commented Jul 31, 2018

/sig node

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.