Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing logic for v1beta1.Event API #65782

Merged
merged 1 commit into from May 17, 2019

Conversation

@yastij
Copy link
Member

commented Jul 3, 2018

What this PR does / why we need it: This PR implements kubernetes/enhancements#383 API logic. migration of relevent controller will follow after this PR

Which issue(s) this PR fixes : Fixes #56694

Special notes for your reviewer:

Release note:

Implementing deduplication logic for v1beta1.Event API
@yastij

This comment has been minimized.

Copy link
Member Author

commented Jul 3, 2018

@idealhack

This comment has been minimized.

Copy link
Member

commented Jul 4, 2018

/ok-to-test

@timothysc

This comment has been minimized.

Copy link
Member

commented Jul 13, 2018

@timothysc timothysc removed their assignment Jul 13, 2018

@wojtek-t

This comment has been minimized.

Copy link
Member

commented Jul 14, 2018

/assign @gmarek

@fejta-bot

This comment has been minimized.

Copy link

commented Oct 12, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@yastij

This comment has been minimized.

Copy link
Member Author

commented Oct 12, 2018

/remove-lifecycle stale

@wojtek-t

This comment has been minimized.

Copy link
Member

commented Oct 16, 2018

@yastij - what's the status of this PR?
It's marked as WIP so I would like to understand its status and how do you expect to proceed with this.

@yastij yastij force-pushed the yastij:eventv2-eventf branch from d0d19f8 to a77b0cf Oct 22, 2018

@yastij yastij changed the title WIP: Implementing logic for v1beta1.Event API Implementing logic for v1beta1.Event API Oct 22, 2018

@yastij yastij force-pushed the yastij:eventv2-eventf branch from a77b0cf to 8ff4379 Oct 22, 2018

@yastij yastij force-pushed the yastij:eventv2-eventf branch from 8ff4379 to cae158e Dec 28, 2018

@wojtek-t
Copy link
Member

left a comment

Please don't resolve comments - especially given most of them are still not addressed.

Most of them are from the previous round are not addressed - I'm not going to take another round of review until you those will be addressed.

eventBroadcaster.mu.RLock()
defer eventBroadcaster.mu.RUnlock()
for _, event := range eventBroadcaster.eventCache {

This comment has been minimized.

Copy link
@wojtek-t

wojtek-t May 13, 2019

Member

not solved

@yastij yastij force-pushed the yastij:eventv2-eventf branch 3 times, most recently from 1c32a26 to b37f793 May 13, 2019

@yastij yastij force-pushed the yastij:eventv2-eventf branch from a36bb05 to 1052f8d May 16, 2019

@yastij

This comment has been minimized.

Copy link
Member Author

commented May 16, 2019

/retest

@yastij yastij force-pushed the yastij:eventv2-eventf branch from 1052f8d to 8cbd732 May 16, 2019

@yastij

This comment has been minimized.

Copy link
Member Author

commented May 16, 2019

@wojtek-t - updated and squashed.

@yastij yastij force-pushed the yastij:eventv2-eventf branch from 8cbd732 to 93a5333 May 16, 2019

Implementing logic for v1beta1.Event API
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>

@yastij yastij force-pushed the yastij:eventv2-eventf branch from 93a5333 to 464a994 May 17, 2019

@yastij

This comment has been minimized.

Copy link
Member Author

commented May 17, 2019

/retest

@wojtek-t

This comment has been minimized.

Copy link
Member

commented May 17, 2019

/lgtm
/approve

Let's have this merged and iterate on this further.

@k8s-ci-robot k8s-ci-robot added the lgtm label May 17, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wojtek-t, yastij

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e67c266 into kubernetes:master May 17, 2019

19 of 20 checks passed

pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation yastij authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Job succeeded.
Details
tide In merge pool.
Details
@tedyu

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

I have created #78040 for the above points.

nikhita pushed a commit to nikhita/kubernetes that referenced this pull request Jun 13, 2019
Merge pull request kubernetes#65782 from yastij/eventv2-eventf
Implementing logic for v1beta1.Event API

Kubernetes-commit: e67c266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.