Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.11] GC: remove CRD and APIService from ignored resources #65915

Merged
merged 1 commit into from Jul 9, 2018

Conversation

@nikhita
Copy link
Member

nikhita commented Jul 6, 2018

Fixes partially #65818

This cherry-picks the GC bits for CRD and APIService from #65856. See #65856 (comment) for more details.

Release note:

The garbage collector now supports CustomResourceDefinitions and APIServices.
@nikhita

This comment has been minimized.

Copy link
Member Author

nikhita commented Jul 6, 2018

/sig api-machinery
/kind bug
/priority important-soon

/assign @liggitt
/cc @deads2k @sttts

/assign @foxish
for cherry-pick approval

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jul 6, 2018

/lgtm
/milestone v1.11
/status approved-for-milestone

@nikhita

This comment has been minimized.

Copy link
Member Author

nikhita commented Jul 6, 2018

/assign @caesarxuchao
for approval

@xmudrii

This comment has been minimized.

Copy link
Member

xmudrii commented Jul 6, 2018

@nikhita Do we need to cherry pick it to v1.10 as it's affected too?

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jul 6, 2018

@xmudrii: changing LGTM is restricted to assignees, and only kubernetes/kubernetes repo collaborators may be assigned issues.

In response to this:

@nikhita Do we need to cherry pick it to v1.10 as it's affected too?

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jul 6, 2018

@nikhita Do we need to cherry pick it to v1.10 as it's affected too?

/lgtm

yes, these should never have been included.

@nikhita nikhita force-pushed the nikhita:release-1.11-gc-ignored-resources branch from a9ce3fe to de4d07c Jul 6, 2018

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jul 6, 2018

@nikhita

This comment has been minimized.

Copy link
Member Author

nikhita commented Jul 6, 2018

I think this should be cherry-picked to 1.9 too. (sending a PR for both)

@xmudrii

This comment has been minimized.

Copy link
Member

xmudrii commented Jul 6, 2018

@liggitt Can I try it? @nikhita Do you want?

@nikhita

This comment has been minimized.

Copy link
Member Author

nikhita commented Jul 6, 2018

@liggitt Can I try it? @nikhita Do you want?

Feel free to send a PR. :)

@xmudrii

This comment has been minimized.

Copy link
Member

xmudrii commented Jul 6, 2018

@nikhita There's also pkg/quota/install/registry.go. Is it needed to remove CRDs and APIServices from that one too?

Also, is removal needed for other resources from #65856?

Feel free to send a PR. :)

Okay, in a moment. :)

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jul 6, 2018

There's also pkg/quota/install/registry.go? Is it needed to remove CRDs and APIServices from that one too?

that's irrelevant, since they're not namespaced objects

@xmudrii

This comment has been minimized.

Copy link
Member

xmudrii commented Jul 6, 2018

@liggitt @nikhita Okay, sounds good to me.

Created #65916, I need /ok-to-test and cherry-pick approval.

@nikhita

This comment has been minimized.

Copy link
Member Author

nikhita commented Jul 6, 2018

Created #65918 against 1.9 since we maintain three releases at a time (1.11, 1.10 and 1.9 right now).

@nikhita

This comment has been minimized.

Copy link
Member Author

nikhita commented Jul 6, 2018

since this has kube-controller-manager changes:

/assign @deads2k
for approval

@deads2k

This comment has been minimized.

Copy link
Contributor

deads2k commented Jul 6, 2018

/approve

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jul 7, 2018

/lgtm

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 9, 2018

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@caesarxuchao @deads2k @foxish @liggitt @nikhita

Pull Request Labels
  • sig/api-machinery: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help
@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 9, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@caesarxuchao

This comment has been minimized.

Copy link
Member

caesarxuchao commented Jul 9, 2018

Sorry I was ooo last week.

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jul 9, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, deads2k, liggitt, nikhita, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 9, 2018

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit e403f7e into kubernetes:release-1.11 Jul 9, 2018

16 of 17 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-kubemark-e2e-gce-big
Details
cla/linuxfoundation nikhita authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Skipped
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

k8s-github-robot pushed a commit that referenced this pull request Jul 10, 2018

Kubernetes Submit Queue
Merge pull request #65916 from xmudrii/release-1.10-ignored-res
Automatic merge from submit-queue.

[1.10] gc: remove crd and apiservice from ignored resources

Fixes #65818

This PR cherry-picks CRD and APIService removal from GC ignored resources, from #65856 and #65915.

**Release note**:
```release-note
The garbage collector now supports CustomResourceDefinitions and APIServices.
```

/cc @nikhita @liggitt 
/sig api-machinery
/kind bug
/priority important-soon

@nikhita nikhita deleted the nikhita:release-1.11-gc-ignored-resources branch Jul 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.