Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: pause image should be arch agnostic, as it is a manifest list #65920

Merged
merged 1 commit into from Jul 7, 2018

Conversation

@dims
Copy link
Member

dims commented Jul 6, 2018

Signed-off-by: Davanum Srinivas davanum@gmail.com

What this PR does / why we need it:

pause image is backed by a manifest list. so we should not use the arch image when reporting using say kubeadm config image list

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes kubernetes/kubeadm#962

Special notes for your reviewer:

Release note:

kubeadm: Fix pause image to not use architecture, as it is a manifest list
pause image should be arch agnostic
Change-Id: I4997ace30077335767bca402a8b98202c91b950b
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims

This comment has been minimized.

Copy link
Member Author

dims commented Jul 6, 2018

/assign @luxas

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Jul 6, 2018

@dims could you please add kubeadm: in the release note.

@chuckha

This comment has been minimized.

Copy link
Member

chuckha commented Jul 6, 2018

/lgtm

thanks for the fast patch!

@luxas

luxas approved these changes Jul 6, 2018

Copy link
Member

luxas left a comment

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jul 6, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha, dims, luxas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@luxas luxas changed the title pause image should be arch agnostic kubeadm: pause image should be arch agnostic, as it is a manifest list Jul 6, 2018

@luxas

This comment has been minimized.

Copy link
Member

luxas commented Jul 6, 2018

Thanks a lot @dims 😄!! Can you cherrypick it to v1.11 as well 😉?

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Jul 6, 2018

@luxas Done!

@luxas luxas referenced this pull request Jul 6, 2018

Closed

Cherrypick tracking issue for v1.11 #958

8 of 9 tasks complete
@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 7, 2018

Automatic merge from submit-queue (batch tested with PRs 65946, 65904, 65913, 65906, 65920). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit d51bfcd into kubernetes:master Jul 7, 2018

17 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation dims authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

k8s-github-robot pushed a commit that referenced this pull request Jul 9, 2018

Kubernetes Submit Queue
Merge pull request #65923 from dims/automated-cherry-pick-of-#65920-u…
…pstream-release-1.11

Automatic merge from submit-queue.

Automated cherry pick of #65920: pause image should be arch agnostic

Cherry pick of #65920 on release-1.11.

#65920: pause image should be arch agnostic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.