Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crictl to v1.11.1. #66152

Merged
merged 1 commit into from Jul 20, 2018

Conversation

@Random-Liu
Copy link
Member

Random-Liu commented Jul 13, 2018

@Random-Liu

This comment has been minimized.

Copy link
Member Author

Random-Liu commented Jul 13, 2018

/status approved-for-milestone

@feiskyer

This comment has been minimized.

Copy link
Member

feiskyer commented Jul 13, 2018

lgtm
/retest

@luxas
Copy link
Member

luxas left a comment

/hold
@Random-Liu please update the community debs/rpms as well. Both here in build/ and in k8s/release
cc @chuckha

@Random-Liu

This comment has been minimized.

Copy link
Member Author

Random-Liu commented Jul 13, 2018

@luxas Thanks for pointing out! Will do.

@Random-Liu

This comment has been minimized.

Copy link
Member Author

Random-Liu commented Jul 13, 2018

@luxas Do we need to change build/debs/BUILD? I feel like as long as crictl is >=1.11.0, it should be fine.

@chuckha

This comment has been minimized.

Copy link
Member

chuckha commented Jul 13, 2018

What luxas is saying is that this bazel build process is not being used, but we keep it up to date. The real debs are built out of kubernetes/release. That's an entirely different way of building debs & rpms so you'll have to make the change there in addition to here.

We keep these synchronized hoping that one day we can transition to bazel entirely and not use kubernetes/release.

@Random-Liu Random-Liu force-pushed the Random-Liu:update-crictl branch from 7889b24 to 31ee5af Jul 13, 2018

@Random-Liu

This comment has been minimized.

Copy link
Member Author

Random-Liu commented Jul 13, 2018

@luxas @chuckha Done. :)

@yujuhong

This comment has been minimized.

Copy link
Member

yujuhong commented Jul 13, 2018

/retest
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 13, 2018

@yujuhong

This comment has been minimized.

Copy link
Member

yujuhong commented Jul 13, 2018

/assign @luxas
/assign @chuckha
for build/debs approval

@luxas

This comment has been minimized.

Copy link
Member

luxas commented Jul 17, 2018

Finally, I got access to a computer and can link to the location that needs to change in k8s/k8s as well (what I meant earlier but described very vaguely): https://github.com/kubernetes/kubernetes/blob/master/build/workspace.bzl#L15. Please bump that version and then this LGTM 👍

@Random-Liu

This comment has been minimized.

Copy link
Member Author

Random-Liu commented Jul 18, 2018

@luxas Ha, it is there... Will do. :)

@Random-Liu Random-Liu force-pushed the Random-Liu:update-crictl branch from c83cca4 to cf14d25 Jul 18, 2018

@Random-Liu

This comment has been minimized.

Copy link
Member Author

Random-Liu commented Jul 18, 2018

@luxas Done. Thanks for reviewing!

@Random-Liu Random-Liu force-pushed the Random-Liu:update-crictl branch from cf14d25 to fc00317 Jul 18, 2018

@chuckha

This comment has been minimized.

Copy link
Member

chuckha commented Jul 18, 2018

Need to update RPM as well because of some technical debt as commented https://github.com/Random-Liu/kubernetes/blob/fc003179f053551a261d70ad2d00e3a5d6210ac6/build/rpms/cri-tools.spec#L14

This was my failed attempt at cleaning up the duplication of version. It would be great to get something like this incorporated.

Update crictl to v1.11.1.
Signed-off-by: Lantao Liu <lantaol@google.com>

@Random-Liu Random-Liu force-pushed the Random-Liu:update-crictl branch from fc00317 to 330ed52 Jul 19, 2018

@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels Jul 19, 2018

@Random-Liu

This comment has been minimized.

Copy link
Member Author

Random-Liu commented Jul 19, 2018

@chuckha Done.

@foxish

This comment has been minimized.

Copy link
Member

foxish commented Jul 19, 2018

Waiting for lgtm and approval on this one.

@Random-Liu

This comment has been minimized.

Copy link
Member Author

Random-Liu commented Jul 19, 2018

@luxas @chuckha Ping for LGTM. :)

@dchen1107 Can you help me approve this PR? Thanks! /cc @yujuhong

@luxas

luxas approved these changes Jul 20, 2018

Copy link
Member

luxas left a comment

/lgtm
/approve
Thanks a lot @Random-Liu! Now for the next time we have a reference PR and doesn't have to go through all of this back and forth again ;)

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 20, 2018

@luxas

This comment has been minimized.

Copy link
Member

luxas commented Jul 20, 2018

/hold cancel

@dchen1107

This comment has been minimized.

Copy link
Member

dchen1107 commented Jul 20, 2018

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jul 20, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, luxas, Random-Liu, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 20, 2018

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@Random-Liu @chuckha @dchen1107 @foxish @luxas @yujuhong

Pull Request Labels
  • sig/gcp sig/node: Pull Request will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/bug: Fixes a bug discovered during the current release.
Help
@Random-Liu

This comment has been minimized.

Copy link
Member Author

Random-Liu commented Jul 20, 2018

@foxish Ping for cherrypick approval.

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 20, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jul 20, 2018

@Random-Liu: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws 330ed52 link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 20, 2018

Automatic merge from submit-queue (batch tested with PRs 66152, 66406, 66218, 66278, 65660). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 25df60b into kubernetes:master Jul 20, 2018

11 of 18 checks passed

pull-kubernetes-e2e-kops-aws Job failed.
Details
Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
pull-kubernetes-e2e-gce Job triggered.
Details
pull-kubernetes-e2e-gce-100-performance Job triggered.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
pull-kubernetes-verify Job triggered.
Details
cla/linuxfoundation Random-Liu authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details

k8s-github-robot pushed a commit that referenced this pull request Jul 23, 2018

Kubernetes Submit Queue
Merge pull request #66470 from Random-Liu/automated-cherry-pick-of-#6…
…6152-upstream-release-1.11

Automatic merge from submit-queue.

Automated cherry pick of #66152: Update crictl to v1.11.1.

Cherry pick of #66152 on release-1.11.

#66152: Update crictl to v1.11.1.

```release-note
Update crictl to v1.11.1.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.