Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare stateful set updates semantically #66165

Merged
merged 1 commit into from Jul 17, 2018

Conversation

@liggitt
Copy link
Member

liggitt commented Jul 13, 2018

Fixes #66137

fixes a validation error that could prevent updates to StatefulSet objects containing non-normalized resource requests
@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Jul 13, 2018

/sig apps
/kind bug
/priority important-soon
@kubernetes/sig-apps-pr-reviews

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Jul 13, 2018

/retest

1 similar comment
@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Jul 14, 2018

/retest

@@ -149,7 +149,7 @@ func ValidateStatefulSetUpdate(statefulSet, oldStatefulSet *apps.StatefulSet) fi
restoreStrategy := statefulSet.Spec.UpdateStrategy
statefulSet.Spec.UpdateStrategy = oldStatefulSet.Spec.UpdateStrategy

if !reflect.DeepEqual(statefulSet.Spec, oldStatefulSet.Spec) {
if !apiequality.Semantic.DeepEqual(statefulSet.Spec, oldStatefulSet.Spec) {

This comment has been minimized.

@nikhita

nikhita Jul 15, 2018

Member

this is used at one more place:

if !reflect.DeepEqual(pdb.Spec, oldPdb.Spec) {
allErrs = append(allErrs, field.Forbidden(field.NewPath("spec"), "updates to poddisruptionbudget spec are forbidden."))
}

This comment has been minimized.

@liggitt

liggitt Jul 16, 2018

Author Member

another sweep could be good, but I didn't see anything under that object that semantic equality would affect. I'd probably keep this PR focused on statefulset, since we want to backport it

@nikhita

This comment has been minimized.

Copy link
Member

nikhita commented Jul 16, 2018

👍 lgtm from my side.

@tnozicka
Copy link
Contributor

tnozicka left a comment

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jul 17, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 17, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 17, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 8246dfa into kubernetes:master Jul 17, 2018

16 of 17 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-kubemark-e2e-gce-big
Details
cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

k8s-github-robot pushed a commit that referenced this pull request Jul 18, 2018

Kubernetes Submit Queue
Merge pull request #66167 from liggitt/automated-cherry-pick-of-#6616…
…5-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #66165: Compare stateful set updates semantically

Cherry pick of #66165 on release-1.10.

#66165: Compare stateful set updates semantically

```release-note
fixes a validation error that could prevent updates to StatefulSet objects containing non-normalized resource requests
```

k8s-github-robot pushed a commit that referenced this pull request Jul 19, 2018

Kubernetes Submit Queue
Merge pull request #66166 from liggitt/automated-cherry-pick-of-#6616…
…5-upstream-release-1.11

Automatic merge from submit-queue.

Automated cherry pick of #66165: Compare stateful set updates semantically

Cherry pick of #66165 on release-1.11.

#66165: Compare stateful set updates semantically

```release-note
fixes a validation error that could prevent updates to StatefulSet objects containing non-normalized resource requests
```

@liggitt liggitt deleted the liggitt:statefulset-semantic-equality branch Jul 20, 2018

k8s-github-robot pushed a commit that referenced this pull request Jul 25, 2018

Kubernetes Submit Queue
Merge pull request #66168 from liggitt/automated-cherry-pick-of-#6616…
…5-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #66165: Compare stateful set updates semantically

Cherry pick of #66165 on release-1.9.

#66165: Compare stateful set updates semantically

```release-note
fixes a validation error that could prevent updates to StatefulSet objects containing non-normalized resource requests
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.