Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove patch retry conflict detection #66171

Merged
merged 1 commit into from Jul 21, 2018

Conversation

@liggitt
Copy link
Member

liggitt commented Jul 13, 2018

Minimal backport of #63146
Fixes #58002

Fixes spurious patch errors for CRDs
Fixes patch errors for nodes when the watch cache has a persistently stale version of an object

fixes spurious "meaningful conflict" error encountered by nodes attempting to update status, which could cause them to be considered unready
Remove patch retry conflict detection
Minimal backport of #63146

Fixes spurious patch errors for CRDs
Fixes patch errors for nodes when the watch cache has a persistently stale version of an object
@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Jul 13, 2018

/sig api-machinery
/kind bug
/milestone 1.9
/priority important-soon
/assign @mbohlool

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jul 13, 2018

@liggitt: The provided milestone is not valid for this repository. Milestones in this repository: [next-candidate, v1.10, v1.11, v1.12, v1.13, v1.4, v1.5, v1.6, v1.7, v1.8, v1.9]

Use /milestone clear to clear the milestone.

In response to this:

/sig api-machinery
/kind bug
/milestone 1.9
/priority important-soon
/assign @mbohlool

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Jul 13, 2018

/retest

@fedebongio

This comment has been minimized.

Copy link
Contributor

fedebongio commented Jul 19, 2018

/cc @mbohlool

@mbohlool

This comment has been minimized.

Copy link
Member

mbohlool commented Jul 20, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 20, 2018

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 20, 2018

/test all

Tests are more than 96 hours old. Re-running tests.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jul 20, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mbohlool

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 21, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 21, 2018

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 836f7ab into kubernetes:release-1.9 Jul 21, 2018

17 of 18 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-kubemark-e2e-gce-big
Details
cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Skipped
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Skipped
pull-kubernetes-verify Job succeeded.
Details

ypnuaa037 added a commit to ypnuaa037/kubernetes that referenced this pull request Jan 25, 2019

Remove patch retry conflict detection
Minimal backport of kubernetes#63146

Fixes spurious patch errors for CRDs
Fixes patch errors for nodes when the watch cache has a persistently stale version of an object

PR: kubernetes#66171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.