Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user assigned MSI support #66180

Merged
merged 1 commit into from Jul 23, 2018

Conversation

Projects
None yet
7 participants
@kkmsft
Copy link
Contributor

kkmsft commented Jul 13, 2018

What this PR does / why we need it:
Adds the support for generating tokens via user assigned MSI.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Add support for using User Assigned MSI (https://docs.microsoft.com/en-us/azure/active-directory/managed-service-identity/overview) with Kubernetes cluster on Azure.
@kkmsft

This comment has been minimized.

Copy link
Contributor Author

kkmsft commented Jul 13, 2018

// UserAssignedMSI contains the Client ID of the user assigned MSI which is assigned to the underlying VMs. If empty the user assigned identity is not used.
// More details of the user assigned identity can be found at: https://docs.microsoft.com/en-us/azure/active-directory/managed-service-identity/overview
// For the user assigned identity specified here to be used, the UseManagedIdentityExtension has to be set to true.
UserAssignedMSI string `json:"userAssignedMSI" yaml:"userAssignedMSI"`

This comment has been minimized.

@feiskyer

feiskyer Jul 16, 2018

Member

use UserAssignedIdentityID for clear? UserAssignedMSI seems overlapping with UseManagedIdentityExtension.

if config.UseManagedIdentityExtension {
glog.V(2).Infoln("azure: using managed identity extension to retrieve access token")
msiEndpoint, err := adal.GetMSIVMEndpoint()
if err != nil {
return nil, fmt.Errorf("Getting the managed service identity endpoint: %v", err)
}
if len(config.UserAssignedMSI) > 0 {
glog.V(2).Info("azure: using User Assigned MSI to retrieve access token")

This comment has been minimized.

@khenidak

khenidak Jul 17, 2018

Contributor

nit: this is a bit too high verbosity. most clusters run with 2 -- can we make it 4?

env.ServiceManagementEndpoint,
config.UserAssignedMSI)
}
glog.V(2).Info("azure: using System Assigned MSI to retrieve access token")

This comment has been minimized.

@khenidak

khenidak Jul 17, 2018

Contributor

same as above. let us use 4

@khenidak

This comment has been minimized.

Copy link
Contributor

khenidak commented Jul 17, 2018

Let us remove the wip tag and prep this for merge. Thanks a lot !

@kkmsft kkmsft force-pushed the kkmsft:user_assigned_msi branch from f5fd04a to 2554c53 Jul 20, 2018

@kkmsft kkmsft changed the title [WIP] Add user assigned MSI support Add user assigned MSI support Jul 20, 2018

@khenidak

This comment has been minimized.

Copy link
Contributor

khenidak commented Jul 20, 2018

/approve

@khenidak

This comment has been minimized.

Copy link
Contributor

khenidak commented Jul 20, 2018

/retest

@feiskyer

This comment has been minimized.

Copy link
Member

feiskyer commented Jul 23, 2018

/ok-to-test

@feiskyer
Copy link
Member

feiskyer left a comment

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jul 23, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, khenidak, kkmsft

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kkmsft

This comment has been minimized.

Copy link
Contributor Author

kkmsft commented Jul 23, 2018

/test pull-kubernetes-e2e-gce

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jul 23, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

3 similar comments
@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jul 23, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jul 23, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jul 23, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 23, 2018

Automatic merge from submit-queue (batch tested with PRs 62423, 66180, 66492, 66506, 65242). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 2beab86 into kubernetes:master Jul 23, 2018

18 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation kkmsft authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@marpaia

This comment has been minimized.

Copy link
Member

marpaia commented Jul 25, 2018

/sig azure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.