New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ip-masq-agent daemonset will be scheduled in all nodes. #66260

Merged
merged 1 commit into from Aug 8, 2018

Conversation

Projects
None yet
7 participants
@tanshanshan
Member

tanshanshan commented Jul 17, 2018

What this PR does / why we need it:
ip-masq-agent tolerate NoSchedule and NoExecute so that it will be scheduled in all nodes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #66255

Special notes for your reviewer:

Release note:

Add NoSchedule/NoExecute tolerations to ip-masq-agent, ensuring it to be scheduled in all nodes except master.
@grayluck

This comment has been minimized.

Show comment
Hide comment
@grayluck

grayluck Jul 17, 2018

Contributor

Could you update the commit message?

Instead of fixtants, let's do a more informative comment message like Add NoSchedule and NoExecute tolerations to ip-masq-agent.

Contributor

grayluck commented Jul 17, 2018

Could you update the commit message?

Instead of fixtants, let's do a more informative comment message like Add NoSchedule and NoExecute tolerations to ip-masq-agent.

@grayluck

This comment has been minimized.

Show comment
Hide comment
@grayluck

grayluck Jul 18, 2018

Contributor

/assign @dchen1107

Contributor

grayluck commented Jul 18, 2018

/assign @dchen1107

@bowei

This comment has been minimized.

Show comment
Hide comment
@bowei

bowei Aug 2, 2018

Member

/lgtm

@dchen1107 for approval

Member

bowei commented Aug 2, 2018

/lgtm

@dchen1107 for approval

@grayluck

This comment has been minimized.

Show comment
Hide comment
@grayluck

grayluck Aug 2, 2018

Contributor

/hold
Need someone to confirm that the tolerance is appropriate.

Contributor

grayluck commented Aug 2, 2018

/hold
Need someone to confirm that the tolerance is appropriate.

@grayluck

This comment has been minimized.

Show comment
Hide comment
@grayluck

grayluck Aug 3, 2018

Contributor

/retest

Contributor

grayluck commented Aug 3, 2018

/retest

1 similar comment
@grayluck

This comment has been minimized.

Show comment
Hide comment
@grayluck

grayluck Aug 7, 2018

Contributor

/retest

Contributor

grayluck commented Aug 7, 2018

/retest

@grayluck

This comment has been minimized.

Show comment
Hide comment
@grayluck

grayluck Aug 7, 2018

Contributor

@dchen1107 Friendly ping, should be really quick

Contributor

grayluck commented Aug 7, 2018

@dchen1107 Friendly ping, should be really quick

@dchen1107

This comment has been minimized.

Show comment
Hide comment
@dchen1107

dchen1107 Aug 7, 2018

Member

/lgtm

Member

dchen1107 commented Aug 7, 2018

/lgtm

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 7, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, dchen1107, tanshanshan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Aug 7, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, dchen1107, tanshanshan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@grayluck

This comment has been minimized.

Show comment
Hide comment
@grayluck

grayluck Aug 7, 2018

Contributor

/hold cancel
Thanks guys! Buckle the seat belts.

Contributor

grayluck commented Aug 7, 2018

/hold cancel
Thanks guys! Buckle the seat belts.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Aug 8, 2018

Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

Contributor

k8s-merge-robot commented Aug 8, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Aug 8, 2018

Contributor

Automatic merge from submit-queue (batch tested with PRs 66634, 66260). If you want to cherry-pick this change to another branch, please follow the instructions here.

Contributor

k8s-merge-robot commented Aug 8, 2018

Automatic merge from submit-queue (batch tested with PRs 66634, 66260). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 3c05d92 into kubernetes:master Aug 8, 2018

10 of 18 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
pull-kubernetes-e2e-gce Job triggered.
Details
pull-kubernetes-e2e-gce-100-performance Job triggered.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job triggered.
Details
pull-kubernetes-e2e-kops-aws Job triggered.
Details
pull-kubernetes-integration Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
pull-kubernetes-verify Job triggered.
Details
cla/linuxfoundation tanshanshan authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 8, 2018

Contributor

@tanshanshan: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-integration c8a4c65 link /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Contributor

k8s-ci-robot commented Aug 8, 2018

@tanshanshan: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-integration c8a4c65 link /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@grayluck

This comment has been minimized.

Show comment
Hide comment
@grayluck

grayluck Aug 10, 2018

Contributor

@tanshanshan Could you please add a release note to this PR, saying something like: Add NoSchedule/NoExecute tolerations to ip-masq-agent, ensuring it to be scheduled in all nodes except master.
Thanks!

Contributor

grayluck commented Aug 10, 2018

@tanshanshan Could you please add a release note to this PR, saying something like: Add NoSchedule/NoExecute tolerations to ip-masq-agent, ensuring it to be scheduled in all nodes except master.
Thanks!

@grayluck

This comment has been minimized.

Show comment
Hide comment
@grayluck

grayluck Aug 10, 2018

Contributor

It's for cherrypicking the change into previous versions and I am not able to change the release note.

Contributor

grayluck commented Aug 10, 2018

It's for cherrypicking the change into previous versions and I am not able to change the release note.

k8s-merge-robot added a commit that referenced this pull request Aug 13, 2018

Merge pull request #67151 from grayluck/automated-cherry-pick-of-#66260
…-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #66260: Add NoSchedule and NoExecute tolerations to ip-masq-agent

Cherry pick of #66260 on release-1.10.

#66260: Add NoSchedule and NoExecute tolerations to ip-masq-agent
@neolit123

This comment has been minimized.

Show comment
Hide comment
@neolit123

neolit123 Aug 24, 2018

Member

/sig network

Member

neolit123 commented Aug 24, 2018

/sig network

k8s-merge-robot added a commit that referenced this pull request Aug 28, 2018

Merge pull request #67152 from grayluck/automated-cherry-pick-of-#66260
…-upstream-release-1.11

Automatic merge from submit-queue.

Automated cherry pick of #66260: Add NoSchedule and NoExecute tolerations to ip-masq-agent

Cherry pick of #66260 on release-1.11.

#66260: Add NoSchedule and NoExecute tolerations to ip-masq-agent

k8s-ci-robot added a commit that referenced this pull request Sep 10, 2018

Merge pull request #67150 from grayluck/automated-cherry-pick-of-#66260
…-upstream-release-1.9

Automated cherry pick of #66260: Add NoSchedule and NoExecute tolerations to ip-masq-agent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment