Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flake-reporting utility to testing framework #66296

Merged
merged 1 commit into from Jul 24, 2018

Conversation

Projects
None yet
5 participants
@shyamjvs
Copy link
Member

shyamjvs commented Jul 17, 2018

One step towards #66239

/cc @wojtek-t @mborsz
(whoever can review first)

NONE

@k8s-ci-robot k8s-ci-robot requested review from mborsz and wojtek-t Jul 17, 2018

@shyamjvs shyamjvs force-pushed the shyamjvs:flake-reporting-util branch from 96c10b1 to cb902d1 Jul 17, 2018

@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Jul 17, 2018

@shyamjvs shyamjvs force-pushed the shyamjvs:flake-reporting-util branch from cb902d1 to 74d27a9 Jul 17, 2018

@shyamjvs

This comment has been minimized.

Copy link
Member Author

shyamjvs commented Jul 18, 2018

/retest

}
}

func (f *FlakeReport) RecordFlakeIfError(err error, optionalDescription ...interface{}) {

This comment has been minimized.

@mborsz

mborsz Jul 23, 2018

Member

I assume this should be called instead of framework.ExpectNoError.

Do we need to add some thread safety to this library?

This comment has been minimized.

@shyamjvs

shyamjvs Jul 23, 2018

Author Member

Good point - done.

This comment has been minimized.

@shyamjvs

shyamjvs Jul 23, 2018

Author Member

I assume this should be called instead of framework.ExpectNoError

Correct.

@@ -409,6 +420,10 @@ func (f *Framework) CreateNamespace(baseName string, labels map[string]string) (
return ns, err
}

func (f *Framework) RecordFlakeIfError(err error, optionalDescription ...interface{}) {

This comment has been minimized.

@mborsz

mborsz Jul 23, 2018

Member

Could you add some comment to this method?

This comment has been minimized.

@shyamjvs

shyamjvs Jul 23, 2018

Author Member

Done

@mborsz
Copy link
Member

mborsz left a comment

Overall looks good.

if err == nil {
return
}
msg := fmt.Sprintf("Unexpected error occurred: %v")

This comment has been minimized.

@mborsz

mborsz Jul 23, 2018

Member

Something is wrong here.

fmt.Sprintf("Unexpected error occurred: %v", err)?

This comment has been minimized.

@shyamjvs

shyamjvs Jul 23, 2018

Author Member

Done

@mborsz
Copy link
Member

mborsz left a comment

One more comment

@shyamjvs shyamjvs force-pushed the shyamjvs:flake-reporting-util branch from 74d27a9 to 4d34522 Jul 23, 2018

@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Jul 23, 2018

@mborsz

This comment has been minimized.

Copy link
Member

mborsz commented Jul 23, 2018

/lgtm

@shyamjvs shyamjvs force-pushed the shyamjvs:flake-reporting-util branch from 4d34522 to a80c34b Jul 23, 2018

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jul 23, 2018

@shyamjvs

This comment has been minimized.

Copy link
Member Author

shyamjvs commented Jul 23, 2018

Fixed gofmt and govet (hopefully).

@mborsz

This comment has been minimized.

Copy link
Member

mborsz commented Jul 23, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 23, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jul 23, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mborsz, shyamjvs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shyamjvs

This comment has been minimized.

Copy link
Member Author

shyamjvs commented Jul 23, 2018

/retest

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jul 23, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jul 23, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 24, 2018

Automatic merge from submit-queue (batch tested with PRs 66296, 66382). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit adc14cc into kubernetes:master Jul 24, 2018

18 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation shyamjvs authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@shyamjvs shyamjvs deleted the shyamjvs:flake-reporting-util branch Jul 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.