Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a panic due to assignment to nil map #66307

Merged
merged 1 commit into from Jul 18, 2018

Conversation

Projects
None yet
5 participants
@guoshimin
Copy link
Contributor

guoshimin commented Jul 17, 2018

What this PR does / why we need it:
fix a panic due to assignment to nil map

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Special notes for your reviewer:

Release note:

Fixed a panic in the node status update logic when existing node has nil labels.

@guoshimin guoshimin force-pushed the guoshimin:fixnilmap branch from 7516c4f to e8cd28a Jul 17, 2018

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Jul 17, 2018

/release-note-none
/ok-to-test
/kind bug
/lgtm
/cc @kubernetes/sig-node-pr-reviews

@yujuhong

This comment has been minimized.

Copy link
Member

yujuhong commented Jul 18, 2018

@guoshimin could you add a release note so that this can be cherry-picked to older branches?

@guoshimin

This comment has been minimized.

Copy link
Contributor Author

guoshimin commented Jul 18, 2018

@yujuhong Done.

@guoshimin

This comment has been minimized.

Copy link
Contributor Author

guoshimin commented Jul 18, 2018

/retest

@yujuhong

This comment has been minimized.

Copy link
Member

yujuhong commented Jul 18, 2018

/lgtm

Thanks!

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jul 18, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guoshimin, neolit123, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@guoshimin

This comment has been minimized.

Copy link
Contributor Author

guoshimin commented Jul 18, 2018

I don't understand why it's missing the CLA label. I have signed the CLA previously. Can someone help?

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 18, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jul 18, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit d4ac54a into kubernetes:master Jul 18, 2018

16 of 17 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-kubemark-e2e-gce-big
Details
cla/linuxfoundation guoshimin authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.