Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Support dry run in admission plugins #66391
What this PR does / why we need it:
The following is being done in a follow up PR:
Here is a list of the admission controllers that were considered when making this PR:
changed the title from
[WIP] Support dry run in admission controllers
Support dry run in admission controllers
Jul 20, 2018
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
This looks good, I'd like one more thing before we merge, which is in the code that's going to call mutating and validating webhooks: until we fix the API, I'd like that to check for dry-run-ness immediately before calling and fail instead of calling if the request is dry-run.
With that change, I think this PR will get us to the "safe but not feature complete" stage.
@lavalamp I agree with the idea, but actually I think it will still be safe how it is, because right now the dry-run requests are all unconditionally rejected before they even get to this part of the code.
is already in all the handlers.
Before we allow dry run requests through at all, something like this commit will be have to be added
Maybe in a follow up, since the queue is already looking at this one :)…
On Mon, Aug 6, 2018 at 4:35 PM Kubernetes Submit Queue < ***@***.***> wrote: /test all [submit-queue is verifying that this PR is safe to merge] — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#66391 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAngluN-PnD80xF4185SYM4LzLdjib5eks5uONKqgaJpZM4VW0YT> .