Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get load balancer name per provider #66589

Conversation

@MorrisLaw
Copy link
Contributor

commented Jul 25, 2018

What this PR does / why we need it:
GetLoadBalancerName() should be implemented per cloud provider as opposed to one neutral implementation.

This PR will address this by moving cloudprovider.GetLoadBalancerName() to the LoadBalancer interface and then provide an implementation for each cloud provider, while maintaining previously expected functionality.

Which issue(s) this PR fixes:
Fixes #43173

Special notes for your reviewer:
This is a work in progress. Looking for feedback as I work on this, from any interested parties.

Release note:

NONE
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2018

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2018

/assign @andrewsykim

@MorrisLaw MorrisLaw force-pushed the MorrisLaw:get_load_balancer_name_per_provider branch from 199647c to aa467a2 Jul 25, 2018

@MorrisLaw MorrisLaw closed this Jul 25, 2018

@MorrisLaw MorrisLaw force-pushed the MorrisLaw:get_load_balancer_name_per_provider branch from aa467a2 to 0ffee49 Jul 25, 2018

@andrewsykim

This comment has been minimized.

Copy link
Member

commented Jul 25, 2018

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Jul 25, 2018

@MorrisLaw MorrisLaw force-pushed the MorrisLaw:get_load_balancer_name_per_provider branch from bb0d5ee to 0cf722e Jul 25, 2018

@k8s-ci-robot k8s-ci-robot added size/M size/L and removed size/S size/M labels Jul 26, 2018

@@ -686,7 +686,7 @@ func (s *ServiceController) lockedUpdateLoadBalancerHosts(service *v1.Service, h

// It's only an actual error if the load balancer still exists.
if _, exists, err := s.balancer.GetLoadBalancer(context.TODO(), s.clusterName, service); err != nil {
glog.Errorf("External error while checking if load balancer %q exists: name, %v", cloudprovider.GetLoadBalancerName(service), err)
glog.Errorf("External error while checking if load balancer %q exists: name, %v", s.balancer.DefaultLoadBalancerName(service), err)

This comment has been minimized.

Copy link
@andrewsykim

andrewsykim Aug 3, 2018

Member

same here

@MorrisLaw MorrisLaw force-pushed the MorrisLaw:get_load_balancer_name_per_provider branch from 5f61f66 to 6ecec23 Aug 4, 2018

@andrewsykim

This comment has been minimized.

@andrewsykim

This comment has been minimized.

Copy link
Member

commented Aug 7, 2018

/lgtm (for pkg/cloudprovider)

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 7, 2018

@andrewsykim

This comment has been minimized.

Copy link
Member

commented Aug 7, 2018

/assign @bowei

@hogepodge

This comment has been minimized.

Copy link
Member

commented Aug 8, 2018

/lgtm

@dims this look ok on the OS provider side?

@dims

This comment has been minimized.

Copy link
Member

commented Aug 8, 2018

@hogepodge does not seem to change behavior from OpenStack side. So looks good.

@thockin

This comment has been minimized.

Copy link
Member

commented Aug 8, 2018

GCP and generic is good.

/lgtm - let me know when all done, if you still need approval.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, hogepodge, MorrisLaw, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2018

Automatic merge from submit-queue (batch tested with PRs 67061, 66589, 67121, 67149). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit dd4ab76 into kubernetes:master Aug 8, 2018

11 of 18 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
pull-kubernetes-e2e-gce Job triggered.
Details
pull-kubernetes-e2e-gce-100-performance Job triggered.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job triggered.
Details
pull-kubernetes-e2e-kops-aws Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
pull-kubernetes-verify Job triggered.
Details
cla/linuxfoundation MorrisLaw authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
@andrewsykim andrewsykim referenced this pull request Oct 1, 2018
0 of 5 tasks complete

KIVagant referenced this pull request in KIVagant/kubernetes Feb 11, 2019

AWS: Allow to set ELB name with `service.beta.kubernetes.io/aws-load-…
…balancer-name`

After setting the name user must control uniqueness by itself.

Related to kubernetes#29789
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.