Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Changed admission controller to allow volume expansion for all volume plugins #66780
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
Special notes for your reviewer:
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
@gnufied That's actually how I implemented the code first; however, that complicated the unit tests for
I agree having the same logic to check valid plugins in two controllers isn't ideal, but short of a major refactoring, I don't see a better solution. Implementing this logic inside
One outstanding question is whether we should use a single generic event (e.g.,
I do no see why we can't just stop volume/pod from being added to resizemap inside
AddPVCUpdate. Initializing volume plugin manager in tests is not very difficult. For example - https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/kubelet_test.go#L322
Also - preferably - we should not implement
VolumeHost interface again for pvc populator.
@gnufied Good idea regarding passing
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
Aug 14, 2018
16 of 18 checks passed
@kangarlou: The following test failed, say