Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
#50102 Task 1: Move apimachinery/pkg/watch.Until into client-go/tools/watch.UntilWithoutRetry #66906
What this PR does / why we need it:
Dev release note:
@fedebongio: GitHub didn't allow me to assign the following users: wenjiaswe.
I recall discussing where to put it, thought client-go was what you recommended unless I got you wrong.
Renaming was the consensus between reviewers on #50102.
The move is necessary because of import restrictions and because the other Until* functions need to include informers.
a) moving the package breaks them anyways
I don't want to break them twice by moving the function for v1.12 and renaming it in 1.13 where the rest of usages will be replaced and also having to rename the Retry function back to Until. That's why also the rename now since we are already breaking them with package move.
[MILESTONENOTIFIER] Milestone Pull Request Needs Approval
Action required: This pull request must have the
Pull Request Labels
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing