Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ephemeral storage monitoring via filesystem quotas #66928

Open
wants to merge 4 commits into
base: master
from

Conversation

@RobertKrawitz
Copy link
Contributor

RobertKrawitz commented Aug 2, 2018

Use XFS-style quotas to monitor ephemeral storage consumption where possible. Reference https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/0030-20180906-quotas-for-ephemeral-storage.md

kubelet now allows use of XFS quotas (on XFS and suitably configured ext4fs filesystems) to monitor storage consumption for ephemeral storage (currently for emptydir volumes only).  This method of monitoring consumption is faster and more accurate than the old method of walking the filesystem tree.  It does not enforce limits, only monitors consumption.  To utilize this functionality, you must set the feature  gate `LocalStorageCapacityIsolationFSQuotaMonitoring=true`. For ext4fs filesystems, you must create the
filesystem with `mkfs.ext4 -O project <block_device>` and run `tune2fs -Q prjquota `block device`; XFS
filesystems need no additional preparation.  The filesystem must be mounted with option `project` in
`/etc/fstab`.  If your primary partition is the root filesystem, you must also add `rootflags=pquota` to your
GRUB config file.

@k8s-ci-robot k8s-ci-robot requested review from chakri-nelluri and cofyc Aug 2, 2018

@k8s-ci-robot k8s-ci-robot added size/XXL and removed size/XL labels Aug 7, 2018

@RobertKrawitz RobertKrawitz force-pushed the RobertKrawitz:ephemeral-storage-quota-exp branch from bebd4e6 to ac80c5f Aug 7, 2018

@k8s-ci-robot k8s-ci-robot added size/XL and removed size/XXL labels Aug 7, 2018

@RobertKrawitz RobertKrawitz force-pushed the RobertKrawitz:ephemeral-storage-quota-exp branch 6 times, most recently from 12644a2 to 50aaa4e Aug 7, 2018

@k8s-ci-robot k8s-ci-robot added size/XXL and removed size/XL labels Aug 10, 2018

@RobertKrawitz RobertKrawitz force-pushed the RobertKrawitz:ephemeral-storage-quota-exp branch 6 times, most recently from dddaee9 to cfa9fbc Aug 13, 2018

@RobertKrawitz RobertKrawitz force-pushed the RobertKrawitz:ephemeral-storage-quota-exp branch from b0fb1ae to 82e0eb9 Aug 15, 2018

@RobertKrawitz RobertKrawitz force-pushed the RobertKrawitz:ephemeral-storage-quota-exp branch from 82376ef to ab5f1f7 Aug 16, 2018

@RobertKrawitz RobertKrawitz force-pushed the RobertKrawitz:ephemeral-storage-quota-exp branch from a2f9d55 to 31edcd9 Feb 15, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 15, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 15, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RobertKrawitz
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers: derekwaynecarr, luxas, thockin

If they are not already assigned, you can assign the PR to them by writing /assign @derekwaynecarr @luxas @thockin in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RobertKrawitz

This comment has been minimized.

Copy link
Contributor Author

RobertKrawitz commented Feb 15, 2019

@dashpole just rebased this; could you recheck and /lgtm if appropriate?

@dashpole

This comment has been minimized.

Copy link
Contributor

dashpole commented Feb 15, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 15, 2019

@RobertKrawitz

This comment has been minimized.

Copy link
Contributor Author

RobertKrawitz commented Feb 15, 2019

/retest

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 15, 2019

@RobertKrawitz: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-local-e2e-containerized 31edcd9 link /test pull-kubernetes-local-e2e-containerized

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@RobertKrawitz RobertKrawitz referenced this pull request Mar 6, 2019

Closed

REQUEST: New membership for RobertKrawitz #573

6 of 6 tasks complete

RobertKrawitz added some commits Nov 19, 2018

Add e2e test for quota-based eviction.
Positive test is skipped if quotas not available.

@RobertKrawitz RobertKrawitz force-pushed the RobertKrawitz:ephemeral-storage-quota-exp branch from 31edcd9 to cd433cc Mar 19, 2019

@k8s-ci-robot k8s-ci-robot added area/test and removed lgtm labels Mar 19, 2019

@RobertKrawitz

This comment has been minimized.

Copy link
Contributor Author

RobertKrawitz commented Mar 19, 2019

/kind feature

@RobertKrawitz

This comment has been minimized.

Copy link
Contributor Author

RobertKrawitz commented Mar 20, 2019

@dashpole @derekwaynecarr could you lgtm please?

@dashpole

This comment has been minimized.

Copy link
Contributor

dashpole commented Mar 20, 2019

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.