New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#50102 Task 2: Add UntilWithSync #66971

Merged
merged 5 commits into from Aug 23, 2018

Conversation

@tnozicka
Contributor

tnozicka commented Aug 3, 2018

What this PR does / why we need it:
This is a split off from #50102 to go in smaller pieces.

Introduces UntilWithSync based on informer.

Needs #66906 first
/hold

Release note:

NONE

/priority important-soon
/kind bug
(bug after the main PR which is this split from)

@neolit123

This comment has been minimized.

Show comment
Hide comment
@neolit123

neolit123 Aug 6, 2018

Member

/sig api-machinery
/sig cli

Member

neolit123 commented Aug 6, 2018

/sig api-machinery
/sig cli

@fedebongio

This comment has been minimized.

Show comment
Hide comment
@fedebongio

fedebongio commented Aug 6, 2018

/assign @cheftako

@tnozicka

This comment has been minimized.

Show comment
Hide comment
@tnozicka

tnozicka Aug 8, 2018

Contributor

/retest

Contributor

tnozicka commented Aug 8, 2018

/retest

@tnozicka tnozicka changed the title from [WIP] - #50102 Task 2: Add UntilWithSync to #50102 Task 2: Add UntilWithSync Aug 10, 2018

// just fail in that case. On the other hand it can't provide you with guarantees as strong as using simple
// Watch method with Until. It can skip some intermediate events in case of watch function failing but it will
// re-list to recover and you always get an event, if there has been a change, after recovery.
// Also with the current implementation based on DeltaFIFO, order of the events you receive is guaranteed only for

This comment has been minimized.

@tnozicka

tnozicka Aug 10, 2018

Contributor

@smarterclayton as we were talking about it; the order of events is preserved only for objects with the same key - not really sure why deltaFIFO is implemented that way. Maybe you have some context why it was done like that, if that was intentional or just that for controllers it doesn't matter.

@tnozicka

tnozicka Aug 10, 2018

Contributor

@smarterclayton as we were talking about it; the order of events is preserved only for objects with the same key - not really sure why deltaFIFO is implemented that way. Maybe you have some context why it was done like that, if that was intentional or just that for controllers it doesn't matter.

This comment has been minimized.

@tnozicka

tnozicka Aug 10, 2018

Contributor

@smarterclayton you were right to question that ;) I even had a test there with a comment saying informers break order, but this predates a year back when I worked on this first time and seems like my long-term memory sucks.

@tnozicka

tnozicka Aug 10, 2018

Contributor

@smarterclayton you were right to question that ;) I even had a test there with a comment saying informers break order, but this predates a year back when I worked on this first time and seems like my long-term memory sucks.

@tnozicka

This comment has been minimized.

Show comment
Hide comment
@tnozicka

tnozicka Aug 10, 2018

Contributor

@kubernetes/sig-api-machinery-api-reviews ptal

/assign @smarterclayton
/cc @liggitt @wojtek-t

(You can ignore first 4 commits including the first Update Godeps which are just picked from prereq #66906)

Contributor

tnozicka commented Aug 10, 2018

@kubernetes/sig-api-machinery-api-reviews ptal

/assign @smarterclayton
/cc @liggitt @wojtek-t

(You can ignore first 4 commits including the first Update Godeps which are just picked from prereq #66906)

@tnozicka tnozicka referenced this pull request Aug 13, 2018

Open

[WIP] - #50102 Task 3: Until, backed by retry watcher #67350

2 of 2 tasks complete
@tnozicka

This comment has been minimized.

Show comment
Hide comment
@tnozicka

tnozicka Aug 15, 2018

Contributor

#66906 is in; rebased
/hold cancel

@smarterclayton ptal

Contributor

tnozicka commented Aug 15, 2018

#66906 is in; rebased
/hold cancel

@smarterclayton ptal

@tnozicka

This comment has been minimized.

Show comment
Hide comment
@tnozicka

tnozicka Aug 15, 2018

Contributor

/milestone v1.12

Contributor

tnozicka commented Aug 15, 2018

/milestone v1.12

@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Aug 15, 2018

@smarterclayton

This comment has been minimized.

Show comment
Hide comment
@smarterclayton

smarterclayton Aug 20, 2018

Contributor

/approve

but haven't had a chance to go through the PR in detail yet (my previous comments were addressed to the degree I've checked)

Contributor

smarterclayton commented Aug 20, 2018

/approve

but haven't had a chance to go through the PR in detail yet (my previous comments were addressed to the degree I've checked)

@wojtek-t

This comment has been minimized.

Show comment
Hide comment
@wojtek-t

wojtek-t Aug 23, 2018

Member

Thanks for working on that.

/lgtm

Member

wojtek-t commented Aug 23, 2018

Thanks for working on that.

/lgtm

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 23, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, tnozicka, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Aug 23, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, tnozicka, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Aug 23, 2018

Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

Contributor

k8s-merge-robot commented Aug 23, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@tnozicka

This comment has been minimized.

Show comment
Hide comment
@tnozicka

tnozicka Aug 23, 2018

Contributor

/test pull-kubernetes-integration

Contributor

tnozicka commented Aug 23, 2018

/test pull-kubernetes-integration

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Aug 23, 2018

Contributor

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

Contributor

k8s-merge-robot commented Aug 23, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit c4f355a into kubernetes:master Aug 23, 2018

17 of 18 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-integration
Details
cla/linuxfoundation tnozicka authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@tnozicka tnozicka deleted the tnozicka:informer-watcher branch Aug 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment