New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop kube-aggregator container image from release #67157

Merged
merged 1 commit into from Aug 15, 2018

Conversation

@dims
Member

dims commented Aug 8, 2018

What this PR does / why we need it:

First version of this was only standalone, now the code is integrated into kube-apiserver. So the standalone binary and
container are no longer useful.

Change-Id: Ib9369de66b4ecb3451f73ba2a252526d6615b96f

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Remove unused binary and container image for kube-aggregator. The functionality is already integrated into the kube-apiserver.
Drop kube-aggregator container image from release
First version of this was only standalone, now the code is being
vendored by anyone who wants to use it. So the standalone binary and
container are no longer useful.

Change-Id: Ib9369de66b4ecb3451f73ba2a252526d6615b96f
@dims

This comment has been minimized.

Show comment
Hide comment
@dims

This comment has been minimized.

Show comment
Hide comment
@dims

dims Aug 8, 2018

Member

/sig api-machinery
/sig release

Member

dims commented Aug 8, 2018

/sig api-machinery
/sig release

@dims

This comment has been minimized.

Show comment
Hide comment
@dims

dims Aug 8, 2018

Member

/assign @lavalamp
/assign @cblecker

Member

dims commented Aug 8, 2018

/assign @lavalamp
/assign @cblecker

@sttts

This comment has been minimized.

Show comment
Hide comment
@sttts

sttts Aug 9, 2018

Contributor

now the code is being
vendored by anyone who wants to use it

More correct: now it is integrated into kube-apiserver.

Contributor

sttts commented Aug 9, 2018

now the code is being
vendored by anyone who wants to use it

More correct: now it is integrated into kube-apiserver.

@deads2k

This comment has been minimized.

Show comment
Hide comment
@deads2k

deads2k Aug 9, 2018

Contributor

Seems reasonable to me

Contributor

deads2k commented Aug 9, 2018

Seems reasonable to me

@tpepper

This comment has been minimized.

Show comment
Hide comment
@tpepper

tpepper Aug 9, 2018

Contributor

Should the release note include brief mention that its functionality is instead found in kube-apiserver?

Otherwise looks good to me.

Contributor

tpepper commented Aug 9, 2018

Should the release note include brief mention that its functionality is instead found in kube-apiserver?

Otherwise looks good to me.

@dims

This comment has been minimized.

Show comment
Hide comment
@dims

dims Aug 9, 2018

Member

@tpepper done

Member

dims commented Aug 9, 2018

@tpepper done

@lavalamp

This comment has been minimized.

Show comment
Hide comment
@lavalamp

lavalamp Aug 9, 2018

Member

I do not agree that the standalone binary is useless.

It is fine to remove it from the main build and the things we publish. We needn't make it impossible to build, though? Can I still build it separately after this change?

Member

lavalamp commented Aug 9, 2018

I do not agree that the standalone binary is useless.

It is fine to remove it from the main build and the things we publish. We needn't make it impossible to build, though? Can I still build it separately after this change?

@dims

This comment has been minimized.

Show comment
Hide comment
@dims

dims Aug 9, 2018

Member

@lavalamp Just the release oriented stuff is being removed. Please take a peek at the commit.

Member

dims commented Aug 9, 2018

@lavalamp Just the release oriented stuff is being removed. Please take a peek at the commit.

@dims

This comment has been minimized.

Show comment
Hide comment
@dims

dims Aug 13, 2018

Member

/assign @ixdy

Member

dims commented Aug 13, 2018

/assign @ixdy

@lavalamp

This comment has been minimized.

Show comment
Hide comment
@lavalamp

lavalamp Aug 13, 2018

Member

Just the release oriented stuff is being removed. Please take a peek at the commit.

I had, it's not obvious that those files only affect the release.

/lgtm
/approve

Member

lavalamp commented Aug 13, 2018

Just the release oriented stuff is being removed. Please take a peek at the commit.

I had, it's not obvious that those files only affect the release.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 13, 2018

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 13, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Aug 13, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Show comment
Hide comment
@fejta-bot

fejta-bot Aug 14, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Aug 14, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot

This comment has been minimized.

Show comment
Hide comment
@fejta-bot

fejta-bot Aug 15, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Aug 15, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Aug 15, 2018

Contributor

Automatic merge from submit-queue (batch tested with PRs 66177, 66185, 67136, 67157, 65065). If you want to cherry-pick this change to another branch, please follow the instructions here.

Contributor

k8s-merge-robot commented Aug 15, 2018

Automatic merge from submit-queue (batch tested with PRs 66177, 66185, 67136, 67157, 65065). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit b9c17ec into kubernetes:master Aug 15, 2018

18 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation dims authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment