New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved staging/src/k8s.io/client-go/tools/bootstrap to staging/src/k8s… #67356

Merged
merged 1 commit into from Oct 3, 2018

Conversation

@yliaog
Contributor

yliaog commented Aug 14, 2018

What this PR does / why we need it:
Moved bootstrap out of client-go, where it does not belong to.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #64627

Special notes for your reviewer:

Dev-Release note:

action required: client-go release will no longer have bootstrap (k8s.io/client-go/tools/bootstrap) related code. any reference to it will break. Please redirect all references to k8s.io/bootstrap instead.
@yliaog

This comment has been minimized.

Show comment
Hide comment
@yliaog

yliaog Aug 17, 2018

Contributor

/assign @caesarxuchao

Contributor

yliaog commented Aug 17, 2018

/assign @caesarxuchao

@yliaog

This comment has been minimized.

Show comment
Hide comment
@yliaog

yliaog Aug 17, 2018

Contributor

/test pull-kubernetes-e2e-kops-aws

Contributor

yliaog commented Aug 17, 2018

/test pull-kubernetes-e2e-kops-aws

@yliaog

This comment has been minimized.

Show comment
Hide comment
@yliaog

yliaog Aug 17, 2018

Contributor

/assign @sttts

Contributor

yliaog commented Aug 17, 2018

/assign @sttts

@sttts

This comment has been minimized.

Show comment
Hide comment
@sttts
Contributor

sttts commented Aug 20, 2018

@yliaog yliaog referenced this pull request Aug 20, 2018

Merged

added bootstrap repo. #89

@yliaog

This comment has been minimized.

Show comment
Hide comment
@yliaog

yliaog Aug 20, 2018

Contributor

kubernetes/publishing-bot#89 for adding the bootstrap repo

Contributor

yliaog commented Aug 20, 2018

kubernetes/publishing-bot#89 for adding the bootstrap repo

@yliaog

This comment has been minimized.

Show comment
Hide comment
@yliaog

yliaog Aug 20, 2018

Contributor

/test pull-kubernetes-e2e-kops-aws

Contributor

yliaog commented Aug 20, 2018

/test pull-kubernetes-e2e-kops-aws

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 20, 2018

@sttts

This comment has been minimized.

Show comment
Hide comment
@sttts

sttts Aug 21, 2018

Contributor

/approve
/lgtm

/assign @lavalamp

for toplevel approval.

Contributor

sttts commented Aug 21, 2018

/approve
/lgtm

/assign @lavalamp

for toplevel approval.

@k8s-ci-robot k8s-ci-robot removed this from the v1.12 milestone Sep 17, 2018

@neolit123 neolit123 referenced this pull request Sep 18, 2018

Closed

Tracking issue for "Config to v1beta1" #963

19 of 28 tasks complete

@yliaog yliaog referenced this pull request Sep 21, 2018

Closed

request to join kubernetes-sigs #108

1 of 1 task complete
@dims

This comment has been minimized.

Show comment
Hide comment
@dims

dims Sep 24, 2018

Member

/hold cancel

(please feel free to add /lgtm for this to merge)

Member

dims commented Sep 24, 2018

/hold cancel

(please feel free to add /lgtm for this to merge)

@spiffxp

This comment has been minimized.

Show comment
Hide comment
@spiffxp

spiffxp Sep 27, 2018

Member

/retest

Member

spiffxp commented Sep 27, 2018

/retest

@yliaog

This comment has been minimized.

Show comment
Hide comment
@yliaog

yliaog Sep 27, 2018

Contributor

@timothysc @luxas it looks the lgtm label was removed, do you mind to take a look again?

Contributor

yliaog commented Sep 27, 2018

@timothysc @luxas it looks the lgtm label was removed, do you mind to take a look again?

@yliaog

This comment has been minimized.

Show comment
Hide comment
@yliaog

yliaog Sep 27, 2018

Contributor

/retest

Contributor

yliaog commented Sep 27, 2018

/retest

@yliaog

This comment has been minimized.

Show comment
Hide comment
@yliaog

yliaog Sep 27, 2018

Contributor

/test pull-kubernetes-verify

Contributor

yliaog commented Sep 27, 2018

/test pull-kubernetes-verify

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 1, 2018

@yliaog

This comment has been minimized.

Show comment
Hide comment
@yliaog

yliaog Oct 1, 2018

Contributor

/retest

Contributor

yliaog commented Oct 1, 2018

/retest

@fejta-bot

This comment has been minimized.

Show comment
Hide comment
@fejta-bot

fejta-bot Oct 2, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Oct 2, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@cblecker

This comment has been minimized.

Show comment
Hide comment
@cblecker

cblecker Oct 2, 2018

Member

/retest

Member

cblecker commented Oct 2, 2018

/retest

@fejta-bot

This comment has been minimized.

Show comment
Hide comment
@fejta-bot

fejta-bot Oct 2, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Oct 2, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot

This comment has been minimized.

Show comment
Hide comment
@fejta-bot

fejta-bot Oct 2, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Oct 2, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot

This comment has been minimized.

Show comment
Hide comment
@fejta-bot

fejta-bot Oct 2, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Oct 2, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot

This comment has been minimized.

Show comment
Hide comment
@fejta-bot

fejta-bot Oct 2, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Oct 2, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot

This comment has been minimized.

Show comment
Hide comment
@fejta-bot

fejta-bot Oct 2, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Oct 2, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 2, 2018

@yliaog

This comment has been minimized.

Show comment
Hide comment
@yliaog

yliaog Oct 2, 2018

Contributor

/retest

Contributor

yliaog commented Oct 2, 2018

/retest

@yliaog

This comment has been minimized.

Show comment
Hide comment
@yliaog

yliaog Oct 2, 2018

Contributor

again, @timothysc @luxas it looks the lgtm label was removed, do you mind to take a look again?

Contributor

yliaog commented Oct 2, 2018

again, @timothysc @luxas it looks the lgtm label was removed, do you mind to take a look again?

@timothysc

This comment has been minimized.

Show comment
Hide comment
@timothysc

timothysc Oct 3, 2018

Member

/lgtm

Member

timothysc commented Oct 3, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 3, 2018

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 3, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, jbeda, luxas, sttts, timothysc, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Oct 3, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, jbeda, luxas, sttts, timothysc, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c179a9c into kubernetes:master Oct 3, 2018

18 checks passed

cla/linuxfoundation yliaog authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment