Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated comment for DefaultLoadBalancerName to provide further context #67405

Conversation

@MorrisLaw
Copy link
Contributor

commented Aug 14, 2018

What this PR does / why we need it:
Updates the comment for DefaultLoadBalancerName to provide better context and also as a reminder that it should eventually be removed.

Release note:

NONE
@MorrisLaw

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2018

/assign @andrewsykim
/sig cloud-provider

@wgliang

This comment has been minimized.

Copy link
Member

commented Aug 15, 2018

/ok-to-test

@@ -62,8 +62,9 @@ type Clusters interface {
Master(ctx context.Context, clusterName string) (string, error)
}

// TODO(#6812): Use a shorter name that's less likely to be longer than cloud
// providers' name length limits.
// DefaultLoadBalancerName is for getting the load balancer name. It should eventually be removed

This comment has been minimized.

Copy link
@andrewsykim

andrewsykim Aug 15, 2018

Member

What do you think about:

(DEPRECATED) DefaultLoadBalancerName is the default load balancer name that is called from LoadBalancer.GetLoadBalancerName. Use this method to maintain backward compatible names for LoadBalancers that were created prior to Kubernetes v1.12. In the future, each provider should replace this method call in GetLoadBalancerName with a provider-specific implementation that is less cryptic than the Service's UUID.

This comment has been minimized.

Copy link
@MorrisLaw

MorrisLaw Aug 16, 2018

Author Contributor

I think this is good too

@andrewsykim

This comment has been minimized.

Copy link
Member

commented Aug 15, 2018

@MorrisLaw for all provider implementations of GetLoadBalancerName that calls DefaultLoadBalancerName can we add a comment like:

TODO: replace DefaultLoadBalancerName to generate more meaningful loadbalancer names.

@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels Aug 16, 2018

@MorrisLaw

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2018

/retest

@andrewsykim

This comment has been minimized.

Copy link
Member

commented Aug 16, 2018

/lgtm
/approve

Thanks @MorrisLaw!

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 16, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, MorrisLaw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2018

Automatic merge from submit-queue (batch tested with PRs 66793, 67405, 67068, 67501, 67484). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit c927968 into kubernetes:master Aug 17, 2018

18 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation MorrisLaw authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.