New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pod Ready++ cont #67406

Merged
merged 2 commits into from Aug 23, 2018

Conversation

@freehan
Member

freehan commented Aug 14, 2018

@freehan

This comment has been minimized.

Show comment
Hide comment
@freehan

freehan Aug 15, 2018

Member

Rebased

Member

freehan commented Aug 15, 2018

Rebased

@freehan

This comment has been minimized.

Show comment
Hide comment
@freehan

freehan Aug 20, 2018

Member

/test pull-kubernetes-e2e-kops-aws

Member

freehan commented Aug 20, 2018

/test pull-kubernetes-e2e-kops-aws

Show outdated Hide outdated test/e2e/common/pods.go
Show outdated Hide outdated test/e2e/common/pods.go
@freehan

This comment has been minimized.

Show comment
Hide comment
@freehan

freehan Aug 20, 2018

Member

/assign thockin for approval

Member

freehan commented Aug 20, 2018

/assign thockin for approval

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 20, 2018

Contributor

@freehan: GitHub didn't allow me to assign the following users: for, approval.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign thockin for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor

k8s-ci-robot commented Aug 20, 2018

@freehan: GitHub didn't allow me to assign the following users: for, approval.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign thockin for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yujuhong

This comment has been minimized.

Show comment
Hide comment
@yujuhong

yujuhong Aug 20, 2018

Contributor

/lgtm

Contributor

yujuhong commented Aug 20, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 20, 2018

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 21, 2018

Contributor

New changes are detected. LGTM label has been removed.

Contributor

k8s-ci-robot commented Aug 21, 2018

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 21, 2018

@freehan

This comment has been minimized.

Show comment
Hide comment
@freehan

freehan Aug 21, 2018

Member

Rebased. Reapplying lgtm

Member

freehan commented Aug 21, 2018

Rebased. Reapplying lgtm

@freehan freehan added the lgtm label Aug 21, 2018

@tfogo

This comment has been minimized.

Show comment
Hide comment
@tfogo

tfogo Aug 21, 2018

Member

Hi @freehan, I'm Tim, a docs shadow on the 1.12 release team. It looks like as part of this change, the docs would need to be updated (specifically it looks like we may want to update this). Could you please open a placeholder or WIP PR to the release-1.12 branch of k/website?

Member

tfogo commented Aug 21, 2018

Hi @freehan, I'm Tim, a docs shadow on the 1.12 release team. It looks like as part of this change, the docs would need to be updated (specifically it looks like we may want to update this). Could you please open a placeholder or WIP PR to the release-1.12 branch of k/website?

@dims

This comment has been minimized.

Show comment
Hide comment
@dims

dims Aug 22, 2018

Member

/sig node

Member

dims commented Aug 22, 2018

/sig node

@freehan

This comment has been minimized.

Show comment
Hide comment
@freehan

freehan Aug 22, 2018

Member

@tfogo pushed a PR

Member

freehan commented Aug 22, 2018

@tfogo pushed a PR

@thockin

This comment has been minimized.

Show comment
Hide comment
@thockin

thockin Aug 23, 2018

Member

/lgtm
/approve

Member

thockin commented Aug 23, 2018

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 23, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: freehan, thockin, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Aug 23, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: freehan, thockin, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Aug 23, 2018

Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

Contributor

k8s-merge-robot commented Aug 23, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Aug 23, 2018

Contributor

Automatic merge from submit-queue (batch tested with PRs 67031, 67406). If you want to cherry-pick this change to another branch, please follow the instructions here.

Contributor

k8s-merge-robot commented Aug 23, 2018

Automatic merge from submit-queue (batch tested with PRs 67031, 67406). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit a1c3e47 into kubernetes:master Aug 23, 2018

12 of 18 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
pull-kubernetes-e2e-gce Job triggered.
Details
pull-kubernetes-e2e-gce-100-performance Job triggered.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job triggered.
Details
pull-kubernetes-e2e-kops-aws Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation freehan authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment