New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RuntimeHandler to the CRI RunPodSandboxRequest #67518

Merged
merged 1 commit into from Aug 22, 2018

Conversation

@tallclair
Member

tallclair commented Aug 16, 2018

What this PR does / why we need it:

Adds the CRI portion of the RuntimeClass API.

Which issue(s) this PR fixes:
For kubernetes/features#585

Special notes for your reviewer:
The Kubernetes API is still blocked on a decision about alpha field usage, see discussion on sig-architecture. I'd like to start with the CRI piece so we can unblock work on the CRI implementation side to have support ready when Kubernetes support is there.

Release note:

[CRI] Adds a "runtime_handler" field to RunPodSandboxRequest, for selecting the runtime configuration to run the sandbox with (alpha feature).

/sig node
/milestone v1.12
/priority important-soon
/kind api-change

@tallclair

This comment has been minimized.

Show comment
Hide comment
@tallclair

tallclair Aug 16, 2018

Member

Added a bit more detail to the doc comment.

Member

tallclair commented Aug 16, 2018

Added a bit more detail to the doc comment.

@k8s-ci-robot k8s-ci-robot added size/XS and removed size/XL labels Aug 17, 2018

@k8s-ci-robot k8s-ci-robot added size/XL and removed size/XS labels Aug 17, 2018

@tallclair

This comment has been minimized.

Show comment
Hide comment
@tallclair

tallclair Aug 17, 2018

Member

Sorry, forgot to push the generated code. Fixed.

Member

tallclair commented Aug 17, 2018

Sorry, forgot to push the generated code. Fixed.

@yujuhong

This comment has been minimized.

Show comment
Hide comment
@yujuhong

yujuhong Aug 20, 2018

Contributor

@tallclair could you add a release note since it's an API change?
Otherwise, LGTM. Thanks!

Contributor

yujuhong commented Aug 20, 2018

@tallclair could you add a release note since it's an API change?
Otherwise, LGTM. Thanks!

@tallclair

This comment has been minimized.

Show comment
Hide comment
@tallclair

tallclair Aug 21, 2018

Member

Done.

Member

tallclair commented Aug 21, 2018

Done.

@tallclair tallclair referenced this pull request Aug 21, 2018

Open

RuntimeHandler support #879

3 of 4 tasks complete
@yujuhong

This comment has been minimized.

Show comment
Hide comment
@yujuhong

yujuhong Aug 21, 2018

Contributor

/lgtm

Contributor

yujuhong commented Aug 21, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 21, 2018

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 21, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tallclair, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Aug 21, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tallclair, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Show comment
Hide comment
@fejta-bot

fejta-bot Aug 21, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Aug 21, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Aug 22, 2018

Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

Contributor

k8s-merge-robot commented Aug 22, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Aug 22, 2018

Contributor

Automatic merge from submit-queue (batch tested with PRs 67298, 67518, 67635, 67673). If you want to cherry-pick this change to another branch, please follow the instructions here.

Contributor

k8s-merge-robot commented Aug 22, 2018

Automatic merge from submit-queue (batch tested with PRs 67298, 67518, 67635, 67673). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 7cd140a into kubernetes:master Aug 22, 2018

13 of 18 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
pull-kubernetes-e2e-gce Job triggered.
Details
pull-kubernetes-e2e-gce-100-performance Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
pull-kubernetes-local-e2e-containerized Job triggered.
Details
cla/linuxfoundation tallclair authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@tallclair tallclair referenced this pull request Aug 22, 2018

Open

RuntimeHandler support #1751

0 of 3 tasks complete

@Random-Liu Random-Liu referenced this pull request Aug 23, 2018

Closed

Track 1.12 CRI Changes #883

4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment