Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Not split nodes when searching for nodes but doing it all at once #67555
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
Special notes for your reviewer:
This is a follow up PR of #66733.
I don't think we should try too hard to mimic the
Parallelize API that is being replaced here. If there's a pattern that works better for us here, let's go with it.
I don't think we should try too hard to mimic the Parallelize API that is being replaced here. If there's a pattern that works better for us here, let's go with it.
I apologize. I didn't notice that you were adding the util in
client-go. Given that, it makes lots of sense to mimic the Parallelize API.
Indeed, I understand what you mean, maybe a callback function can do the same, just like bsalamat said. And using Context may be too complicated for a public function.
I don't believe that Context should be considered "too complicated" for a public function. In this case, it offers features that we don't need, so a stop channel would also work. (Passing a stop channel around is a very common pattern in k8s, but it's an old pattern that really ought to be replaced with Context.)
As a side note, it would be nice to rewrite the commit description and PR description to more clearly explain the change.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Automatic merge from submit-queue (batch tested with PRs 67555, 68196). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.