New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #67062: Double check PVC if not found in syncVolume. #67559

Merged
merged 1 commit into from Sep 20, 2018

Conversation

Projects
None yet
6 participants
@cofyc
Contributor

cofyc commented Aug 18, 2018

Cherry pick of #67062 on release-1.9.

#67062: Double check PVC if not found in syncVolume.

Double check PVC if not found in syncVolume.
If PV is bound by external PV binder (e.g. kube-scheduler), it's
possible on heavy load that corresponding PVC is not synced to
controller local cache yet.
@cofyc

This comment has been minimized.

Show comment
Hide comment
@cofyc

cofyc Aug 18, 2018

Contributor

/assign @mbohlool
cc @jsafrane for approval

Contributor

cofyc commented Aug 18, 2018

/assign @mbohlool
cc @jsafrane for approval

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Aug 18, 2018

Contributor

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.

Contributor

k8s-merge-robot commented Aug 18, 2018

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.

@jsafrane

This comment has been minimized.

Show comment
Hide comment
@jsafrane

jsafrane Aug 21, 2018

Member

/lgtm

Member

jsafrane commented Aug 21, 2018

/lgtm

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 21, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cofyc, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Aug 21, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cofyc, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsafrane

This comment has been minimized.

Show comment
Hide comment
@jsafrane

jsafrane Aug 23, 2018

Member

/retest

Member

jsafrane commented Aug 23, 2018

/retest

@mbohlool

This comment has been minimized.

Show comment
Hide comment
@mbohlool

mbohlool Sep 17, 2018

Member

I don't see any test for this. Per our patch release requirements, we either need a test or a good reason documented here why we didn't add a unit/integration/e2e test for this.

Member

mbohlool commented Sep 17, 2018

I don't see any test for this. Per our patch release requirements, we either need a test or a good reason documented here why we didn't add a unit/integration/e2e test for this.

@cofyc

This comment has been minimized.

Show comment
Hide comment
@cofyc

cofyc Sep 18, 2018

Contributor

@mbohlool
hi, the behavior has already been covered in current test suite. This fix is only used to improve stability of PV controller on heavy load, and it's hard to simulate API delay in tests.

Contributor

cofyc commented Sep 18, 2018

@mbohlool
hi, the behavior has already been covered in current test suite. This fix is only used to improve stability of PV controller on heavy load, and it's hard to simulate API delay in tests.

@fejta-bot

This comment has been minimized.

Show comment
Hide comment
@fejta-bot

fejta-bot Sep 20, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Sep 20, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 06fe9b3 into kubernetes:release-1.9 Sep 20, 2018

18 of 19 checks passed

Submit Queue Milestone is for a future release and cannot be merged
Details
cla/linuxfoundation cofyc authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Skipped
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Skipped
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment