New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KubeConfig export as yaml for different serviceaccount #67567

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@gitlabbin

gitlabbin commented Aug 19, 2018

What this PR does / why we need it:
feature additions:
This PR add a new feature allow cluster admin export KUBECONFIG to yaml file for different service account in different namespace

kubectl config export --namespace default --serviceaccount test

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

kubectl: add support for exporting a KUBECONFIG for different service accounts in different namespaces using `kubectl config export --namespace <namespace> --serviceaccount <account>`
@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 19, 2018

Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Contributor

k8s-ci-robot commented Aug 19, 2018

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@neolit123

This comment has been minimized.

Show comment
Hide comment
@neolit123

neolit123 Aug 19, 2018

Member

/sig cli
/area kubectl
/kind feature

hi and thank you for this PR!
k8s has some tools to verify the syntax and of the change and run some tests locally:

./hack/verify-bazel.sh
./hack/verify-gofmt.sh
./hack/verify-golint.sh

make sure that these pass.

also please change the release note to:

kubectl: add support for exporting a KUBECONFIG for different service accounts in different namespaces using `kubectl config export --namespace <namespace> --serviceaccount <account>`
Member

neolit123 commented Aug 19, 2018

/sig cli
/area kubectl
/kind feature

hi and thank you for this PR!
k8s has some tools to verify the syntax and of the change and run some tests locally:

./hack/verify-bazel.sh
./hack/verify-gofmt.sh
./hack/verify-golint.sh

make sure that these pass.

also please change the release note to:

kubectl: add support for exporting a KUBECONFIG for different service accounts in different namespaces using `kubectl config export --namespace <namespace> --serviceaccount <account>`
@gitlabbin

This comment has been minimized.

Show comment
Hide comment
@gitlabbin

gitlabbin commented Aug 21, 2018

/assign @smarterclayton

@gitlabbin

This comment has been minimized.

Show comment
Hide comment
@gitlabbin

gitlabbin Aug 21, 2018

@neolit123 , based on your comments, update the code, can you please check again, thanks

gitlabbin commented Aug 21, 2018

@neolit123 , based on your comments, update the code, can you please check again, thanks

@neolit123

This comment has been minimized.

Show comment
Hide comment
@neolit123

neolit123 Aug 21, 2018

Member

@gitlabbin
thank you for the updates!

/ok-to-test

Member

neolit123 commented Aug 21, 2018

@gitlabbin
thank you for the updates!

/ok-to-test

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 22, 2018

Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gitlabbin
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: smarterclayton

If they are not already assigned, you can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Aug 22, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gitlabbin
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: smarterclayton

If they are not already assigned, you can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gitlabbin

This comment has been minimized.

Show comment
Hide comment
@gitlabbin

gitlabbin commented Aug 22, 2018

/retest

@gitlabbin

This comment has been minimized.

Show comment
Hide comment
@gitlabbin

gitlabbin commented Aug 22, 2018

/retest

KubeConfig export as yaml for different serviceaccount
  Feature: kubectl config export --namespace <namespace>  --serviceaccount <serviceaccount>
    - allow cluster admin use kubectl to export KUBECONFIG for
       different service account in different namespace
    - the KUBECONFIG output to console and yaml file
    - test case for KUBECONFIG exporting
@gitlabbin

This comment has been minimized.

Show comment
Hide comment
@gitlabbin

gitlabbin Aug 22, 2018

@neolit123 ,PR does not have lgtm label, merging is blocked, Can you add the label lgtm

gitlabbin commented Aug 22, 2018

@neolit123 ,PR does not have lgtm label, merging is blocked, Can you add the label lgtm

@neolit123

This comment has been minimized.

Show comment
Hide comment
@neolit123

neolit123 Aug 22, 2018

Member

@gitlabbin the maintainers are going to LGTM when they find the time to review your change. 👍

Member

neolit123 commented Aug 22, 2018

@gitlabbin the maintainers are going to LGTM when they find the time to review your change. 👍

@gitlabbin

This comment has been minimized.

Show comment
Hide comment
@gitlabbin

gitlabbin Aug 31, 2018

Any of the owner get a chance to do a review and approve this PR?

gitlabbin commented Aug 31, 2018

Any of the owner get a chance to do a review and approve this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment