New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #62943: set updated replicas #67570

Open
wants to merge 2 commits into
base: release-1.11
from

Conversation

Projects
None yet
5 participants
@sfudeus

sfudeus commented Aug 19, 2018

Cherry pick of #62943 on release-1.11.

#62943: set updated replicas

@k8s-ci-robot k8s-ci-robot added the size/M label Aug 19, 2018

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 19, 2018

Contributor

Hi @sfudeus. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor

k8s-ci-robot commented Aug 19, 2018

Hi @sfudeus. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 19, 2018

Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sfudeus
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: janetkuo

If they are not already assigned, you can assign the PR to them by writing /assign @janetkuo in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Aug 19, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sfudeus
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: janetkuo

If they are not already assigned, you can assign the PR to them by writing /assign @janetkuo in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from kow3ns and tnozicka Aug 19, 2018

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Aug 19, 2018

Contributor

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.

Contributor

k8s-merge-robot commented Aug 19, 2018

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.

@sfudeus

This comment has been minimized.

Show comment
Hide comment
@sfudeus

sfudeus Aug 27, 2018

/assign janetkuo

sfudeus commented Aug 27, 2018

/assign janetkuo

@sfudeus

This comment has been minimized.

Show comment
Hide comment
@sfudeus

sfudeus Sep 18, 2018

@kow3ns @tnozicka @janetkuo Can I do something to get this approved/applied? This is just a cherry-pick from upstream.

sfudeus commented Sep 18, 2018

@kow3ns @tnozicka @janetkuo Can I do something to get this approved/applied? This is just a cherry-pick from upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment