New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for pvcVolume with IsOperationPending() before markPVCResizeInProgress() #67630

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
5 participants
@houjun41544
Copy link
Contributor

houjun41544 commented Aug 21, 2018

…rogress()

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE
@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Aug 21, 2018

/ok-to-test
/assign @gnufied

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Feb 2, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@gnufied

This comment has been minimized.

Copy link
Member

gnufied commented Feb 6, 2019

/lgtm

@houjun41544 can you rebase your branch, the PR itself looks good.

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 6, 2019

@gnufied

This comment has been minimized.

Copy link
Member

gnufied commented Feb 6, 2019

/remove-lifecycle stale

@houjun41544 houjun41544 force-pushed the houjun41544:20180820 branch from 9d47cb6 to 49025cc Feb 11, 2019

@houjun41544

This comment has been minimized.

Copy link
Contributor Author

houjun41544 commented Feb 11, 2019

@gnufied I have rebased the branch.

@houjun41544 houjun41544 force-pushed the houjun41544:20180820 branch from 89bcd09 to 19a0851 Feb 11, 2019

@houjun41544 houjun41544 force-pushed the houjun41544:20180820 branch from ec08761 to a5cde1a Feb 11, 2019

@houjun41544

This comment has been minimized.

Copy link
Contributor Author

houjun41544 commented Feb 11, 2019

/retest

@gnufied

This comment has been minimized.

Copy link
Member

gnufied commented Feb 11, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 11, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, houjun41544

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Feb 11, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 126bb3b into kubernetes:master Feb 12, 2019

17 checks passed

cla/linuxfoundation houjun41544 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment