Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create cli-runtime staging repository #67658

Merged
merged 1 commit into from Aug 21, 2018

Conversation

@soltysh
Copy link
Contributor

commented Aug 21, 2018

What this PR does / why we need it:
This PR creates a designated repository for CLI helpers, which are used for:

  • kubectl itself
  • kubectl plugins
  • commands that want to mimic kubectl behavior

/assign @deads2k @juanvallejo
@seans3 @pwittrock fyi

Release note:

Create cli-runtime staging repository

1. Add API types to this repo. This is for the helpers, not for the types.
2. Directly modify any files under `pkg` in this repo. Those are driven from `k8s.io/kubernetes/staging/src/k8s.io/cli-runtime`.
3. Expect compatibility. This repo is direct support of Kubernetes and the API isn't yet stable enough for API guarantees.

This comment has been minimized.

Copy link
@deads2k

deads2k Aug 21, 2018

Contributor

perhaps 4. Add any type that only makes sense for kubectl. This isn't a helper for kubectl, this is a helper for kubectl-like command line tools. Think things that make cli plugins easier to write.

@soltysh soltysh force-pushed the soltysh:staging_cli_runtime branch from 37f76c1 to e47f7c3 Aug 21, 2018

@deads2k

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2018

lgtm

Get @sttts to have a look and see if there's anything else that needs doing before creating this.

@deads2k

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2018

/approve

@sttts

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2018

Seems good to me. A counterpart PR like kubernetes/publishing-bot#89 would be nice.

@sttts

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2018

/approve

@sttts

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2018

/assign @smarterclayton

for approval of the new staging dir.

@@ -0,0 +1,29 @@
# cli-runtime

Set of helpers for creating kubectl plugins as well as kubectl compatible commands.

This comment has been minimized.

Copy link
@juanvallejo

juanvallejo Aug 21, 2018

Member

Given that we are planning on dog-fooding this package ourselves in kubectl, maybe: Set of helpers for creating kubectl commands, as well as kubectl plugins?

@soltysh soltysh force-pushed the soltysh:staging_cli_runtime branch 2 times, most recently from 6cd7ad8 to 2ac7969 Aug 21, 2018

@soltysh

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2018

I've fixed the comments from David and Juan wrt Readme.

@juanvallejo

This comment has been minimized.

Copy link
Member

commented Aug 21, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 21, 2018

@soltysh soltysh force-pushed the soltysh:staging_cli_runtime branch from 2ac7969 to 5b55e1f Aug 21, 2018

@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 21, 2018

@juanvallejo

This comment has been minimized.

Copy link
Member

commented Aug 21, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 21, 2018

@smarterclayton

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2018

Can you explain a bit the naming of the repo? I.e. why cli-runtime vs other names? Or link to that discussion?

@soltysh

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2018

Can you explain a bit the naming of the repo? I.e. why cli-runtime vs other names? Or link to that discussion?

@smarterclayton @pwittrock and I picked that name, based on the previous repos that are available like controller-runtime, with similar functionality. This was also presented during our previous sig-cli meeting everyone agreed with the name. If you have a better proposal I'm open.

@smarterclayton

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, juanvallejo, smarterclayton, soltysh, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit f077d67 into kubernetes:master Aug 21, 2018

17 of 18 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-kubemark-e2e-gce-big
Details
cla/linuxfoundation soltysh authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@soltysh soltysh deleted the soltysh:staging_cli_runtime branch Aug 22, 2018

@neolit123

This comment has been minimized.

Copy link
Member

commented Aug 24, 2018

/sig cli
for the release note tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.