Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Labels to various OWNERS files #67672

Merged
merged 1 commit into from Aug 21, 2018

Conversation

@dims
Copy link
Member

dims commented Aug 21, 2018

What this PR does / why we need it:

Will reduce the burden of manually adding labels. Information pulled
from:
https://github.com/kubernetes/community/blob/master/sigs.yaml

Change-Id: I17e661e37719f0bccf63e41347b628269cef7c8b

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE
Add Labels to various OWNERS files
Will reduce the burden of manually adding labels. Information pulled
from:
https://github.com/kubernetes/community/blob/master/sigs.yaml

Change-Id: I17e661e37719f0bccf63e41347b628269cef7c8b
@dims

This comment has been minimized.

Copy link
Member Author

dims commented Aug 21, 2018

/assign @spiffxp
/assign @cblecker

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Aug 21, 2018

@spiffxp

This comment has been minimized.

Copy link
Member

spiffxp commented Aug 21, 2018

Thank you for doing this. Did you script this or do it manually?

@spiffxp

This comment has been minimized.

Copy link
Member

spiffxp commented Aug 21, 2018

/sig contributor-experience

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Aug 21, 2018

Manually @spiffxp, i did a small grep command to pull the info i needed from sigs.yaml

grep -e "dir:" -e OWNERS sigs.yaml | grep -e "dir:" -e "https://raw.githubusercontent.com/kubernetes/kubernetes/"
@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Aug 21, 2018

This is awesome, @dims!
/lgtm

@@ -48,3 +48,5 @@ reviewers:
- yifan-gu
- yujuhong
- zmerlynn
labels:
- sig/api-machinery

This comment has been minimized.

Copy link
@nikhita

nikhita Aug 21, 2018

Member

While https://github.com/kubernetes/community/blob/master/sig-api-machinery/README.md#subprojects lists k8s.io/api, my understanding is that individual groups/types are owned by the respective SIG.

That's the reason I didn't add this in: #67596 (comment)

/cc @liggitt
because you are a api-approver

This comment has been minimized.

Copy link
@thockin

thockin Aug 21, 2018

Member

There's a small amount of code here, so it probably demands a SIG, and this seems right to me

@spiffxp

This comment has been minimized.

Copy link
Member

spiffxp commented Aug 21, 2018

FWIW I think you missed a few staging repos at least. Avert your eyes children, hacked up jq incoming

<sigs.yaml yq '.sigs[] | {dir, owners: [(.subprojects // [])[].owners | flatten[] | select(contains("kubernetes/kubernetes"))]} | select(.owners != [])'
{
  "dir": "sig-api-machinery",
  "owners": [
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/cmd/kube-apiserver/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/cmd/kube-controller-manager/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/cmd/cloud-controller-manager/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/cmd/controller-manager/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/kubeapiserver/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/master/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/controller/garbagecollector/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/controller/namespace/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/quota/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/staging/src/k8s.io/apimachinery/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/staging/src/k8s.io/apiserver/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/staging/src/k8s.io/apiextensions-apiserver/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/staging/src/k8s.io/kube-aggregator/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/staging/src/k8s.io/sample-apiserver/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/staging/src/k8s.io/sample-controller/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/staging/src/k8s.io/code-generator/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/staging/src/k8s.io/api/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/staging/src/k8s.io/client-go/OWNERS"
  ]
}
{
  "dir": "sig-apps",
  "owners": [
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/controller/cronjob/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/controller/daemon/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/controller/deployment/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/controller/disruption/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/controller/history/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/controller/job/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/controller/replicaset/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/controller/replication/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/controller/statefulset/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/apis/apps/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/apis/core/v1/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/apis/batch/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/apis/extensions/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/registry/apps/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/registry/batch/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/registry/extensions/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/staging/src/k8s.io/api/apps/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/staging/src/k8s.io/api/core/v1/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/staging/src/k8s.io/api/batch/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/staging/src/k8s.io/api/extensions/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/test/e2e/apps/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/test/integration/daemonset/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/test/integration/deployment/OWNERS"
  ]
}
{
  "dir": "sig-architecture",
  "owners": [
    "https://raw.githubusercontent.com/kubernetes/kubernetes-template-project/master/OWNERS"
  ]
}
{
  "dir": "sig-cli",
  "owners": [
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/kubectl/OWNERS"
  ]
}
{
  "dir": "sig-cloud-provider",
  "owners": [
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/cmd/cloud-controller-manager/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/controller/cloud/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/cloudprovider/OWNERS"
  ]
}
{
  "dir": "sig-cluster-lifecycle",
  "owners": [
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/cluster/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/cmd/kubeadm/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes-anywhere/master/OWNERS"
  ]
}
{
  "dir": "sig-docs",
  "owners": [
    "https://raw.githubusercontent.com/kubernetes/kubernetes-docs-ja/master/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes-docs-ko/master/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes-docs-zh/master/OWNERS"
  ]
}
{
  "dir": "sig-network",
  "owners": [
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/proxy/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/kubelet/network/OWNERS"
  ]
}
{
  "dir": "sig-node",
  "owners": [
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/cmd/kubelet/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/kubelet/OWNERS"
  ]
}
{
  "dir": "sig-release",
  "owners": [
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/build/debian-hyperkube-base/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/cmd/hyperkube/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/cluster/images/hyperkube/OWNERS"
  ]
}
{
  "dir": "sig-scheduling",
  "owners": [
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/cmd/kube-scheduler/OWNERS",
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/scheduler/OWNERS"
  ]
}
{
  "dir": "sig-storage",
  "owners": [
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/volume/OWNERS"
  ]
}
{
  "dir": "sig-testing",
  "owners": [
    "https://raw.githubusercontent.com/kubernetes/kubernetes/master/test/OWNERS"
  ]
}
@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Aug 21, 2018

My poor eyes 🙈

(This is great, @dims!)

@nikhita

This comment has been minimized.

Copy link
Member

nikhita commented Aug 21, 2018

Most of the staging ones were covered in #67596. :)

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Aug 21, 2018

Thanks for the inspiration @nikhita

@nikhita

This comment has been minimized.

Copy link
Member

nikhita commented Aug 21, 2018

Thanks for the inspiration @nikhita

I was inspired by @neolit123 :)

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Aug 21, 2018

thanks @dims!

FYI, i've already submitted a couple of PRs for [pkg|cmd]/kubectl and [pkg|cmd/kubelet:
#67548
#67599

these also add the area/xxxxx labels.
let me know if you want me to close them in case we can get a top level approver here. 🎉

@@ -48,3 +48,5 @@ reviewers:
- yifan-gu
- yujuhong
- zmerlynn
labels:
- sig/api-machinery

This comment has been minimized.

Copy link
@thockin

thockin Aug 21, 2018

Member

There's a small amount of code here, so it probably demands a SIG, and this seems right to me

@thockin

This comment has been minimized.

Copy link
Member

thockin commented Aug 21, 2018

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Aug 21, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, justaugustus, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thockin

This comment has been minimized.

Copy link
Member

thockin commented Aug 21, 2018

/retest

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Aug 21, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit c94ecec into kubernetes:master Aug 21, 2018

17 of 18 checks passed

pull-kubernetes-local-e2e-containerized Job triggered.
Details
Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation dims authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@lavalamp

This comment has been minimized.

Copy link
Member

lavalamp commented Aug 23, 2018

api machinery should not own k8s.io/api--it's making a lot of noise for us.

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Aug 23, 2018

@lavalamp

This comment has been minimized.

Copy link
Member

lavalamp commented Aug 23, 2018

It looks like it got scrambled since I initialized it.

That (https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/api/OWNERS) should belong to sig architecture.

@nikhita

This comment has been minimized.

Copy link
Member

nikhita commented Aug 24, 2018

That (https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/api/OWNERS) should belong to sig architecture.

PR against k/community: kubernetes/community#2584
PR against k/k: #67800

@lavalamp could you lgtm these?

k8s-github-robot pushed a commit that referenced this pull request Aug 24, 2018

Kubernetes Submit Queue
Merge pull request #67800 from nikhita/api-owners-change-to-architecture
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

api: change owners from apimachinery to architecture

Ref: #67672 (comment)
Change in the sigs files in k/community: kubernetes/community#2584

/sig api-machinery
/sig architecture

/cc dims
/assign lavalamp 

**Release note**:

```release-note
NONE
```

k8s-publishing-bot added a commit to kubernetes/api that referenced this pull request Aug 24, 2018

Merge pull request #67800 from nikhita/api-owners-change-to-architecture
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

api: change owners from apimachinery to architecture

Ref: kubernetes/kubernetes#67672 (comment)
Change in the sigs files in k/community: kubernetes/community#2584

/sig api-machinery
/sig architecture

/cc dims
/assign lavalamp 

**Release note**:

```release-note
NONE
```

Kubernetes-commit: 09335d7a49d255d5062477486487944479763cd3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.