Join GitHub today
Pass files to golint one at a time #67675
What this PR does / why we need it:
This change will, instead of golinting once per package, will use xargs to run each file through golint individually.
Special notes for your reviewer:
referenced this pull request
Aug 21, 2018
This is what the failures look like now that it's actually looking at all files:
Adding some more details so that if someone comes across this, it's easier for them to understand the line of thought. :)
This is due to an existing golint bug: golang/lint#68 (comment). If we lint a package using
and skips the linting. Current behaviour was to ignore this error, which also meant that we ignored the linting of these packages all together.
Also, it's not possible to lint the whole package together through
And so we use xargs to make sure we are linting all files and don't hit any errors.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing