Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OpenStack cloud provider report a node hostname address #67748

Merged
merged 1 commit into from Aug 23, 2018

Conversation

Projects
None yet
5 participants
@FengyunPan2
Copy link
Contributor

commented Aug 23, 2018

Related to: #67714
Cloud-provider-reported addresses are authoritative in 1.12, this
preserves default behavior that used the internal dns name as
the "Hostname" address on Node status.

Release note:

The OpenStack cloud provider now reports a `Hostname` address type for nodes
Make OpenStack cloud provider report a node hostname address
Related to: #67714
Cloud-provider-reported addresses are authoritative in 1.12, this
preserves default behavior that used the internal dns name as
the "Hostname" address on Node status.

@FengyunPan2 FengyunPan2 force-pushed the FengyunPan2:report-hostname branch from a6413ad to 641693a Aug 23, 2018

@FengyunPan2

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2018

/test pull-kubernetes-e2e-gce

@yastij

yastij approved these changes Aug 23, 2018

Copy link
Member

left a comment

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FengyunPan2, yastij

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims

dims approved these changes Aug 23, 2018

@yastij

This comment has been minimized.

Copy link
Member

commented Aug 23, 2018

/retest

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit d68e1fc into kubernetes:master Aug 23, 2018

17 of 18 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-kops-aws
Details
cla/linuxfoundation FengyunPan2 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@liggitt liggitt referenced this pull request Aug 27, 2018

Closed

Cloud providers should report node hostname address types #67714

6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.