Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OpenStack cloud provider report a node hostname address #67748

merged 1 commit into from Aug 23, 2018
Changes from all commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.


Just for now

Make OpenStack cloud provider report a node hostname address

Related to: #67714
Cloud-provider-reported addresses are authoritative in 1.12, this
preserves default behavior that used the internal dns name as
the "Hostname" address on Node status.
  • Loading branch information...
FengyunPan2 committed Aug 23, 2018
commit 641693ad0576257e4b913e3bd066dfa6b1ed9cb4
@@ -53,7 +53,10 @@ import (

const (
// ProviderName is the name of the openstack provider
ProviderName = "openstack"
ProviderName = "openstack"

// TypeHostName is the name type of openstack instance
TypeHostName = "hostname"
availabilityZone = "availability_zone"
defaultTimeOut = 60 * time.Second
@@ -498,6 +501,15 @@ func nodeAddresses(srv *servers.Server) ([]v1.NodeAddress, error) {

if srv.Metadata[TypeHostName] != "" {
Type: v1.NodeHostName,
Address: srv.Metadata[TypeHostName],

return addrs, nil

@@ -444,6 +444,10 @@ func TestNodeAddresses(t *testing.T) {
Metadata: map[string]string{
"name": "a1-yinvcez57-0-bvynoyawrhcg-kube-minion-fg5i4jwcc2yy",
TypeHostName: "a1-yinvcez57-0-bvynoyawrhcg-kube-minion-fg5i4jwcc2yy.novalocal",

addrs, err := nodeAddresses(&srv)
@@ -462,6 +466,7 @@ func TestNodeAddresses(t *testing.T) {
{Type: v1.NodeExternalIP, Address: ""},
{Type: v1.NodeExternalIP, Address: ""},
{Type: v1.NodeExternalIP, Address: ""},
{Type: v1.NodeHostName, Address: "a1-yinvcez57-0-bvynoyawrhcg-kube-minion-fg5i4jwcc2yy.novalocal"},

if !reflect.DeepEqual(want, addrs) {
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.