New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dynamic azure disk volume limits #67772

Merged
merged 1 commit into from Aug 27, 2018

Conversation

@andyzhangx
Member

andyzhangx commented Aug 23, 2018

What this PR does / why we need it:
Enable dynamic azure disk volume limits,
This is an azure cloud provider implementation related to feature: Dynamic Maximum volume count

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #66269

Special notes for your reviewer:
This PR use az.VirtualMachineSizesClient.List to list all vm sizes under region, match vm size with current node size, and then got MaxDataDiskCount, the GetVolumeLimits happens in kubelet and will return attachable-volumes-azure-disk in node status as following example:

agentpool-22082114-0
    ...
    allocatable:
      attachable-volumes-azure-disk: "8"
      cpu: "2"
      ephemeral-storage: "28043041951"
      hugepages-1Gi: "0"
      hugepages-2Mi: "0"
      memory: 7034772Ki
      pods: "30"

Release note:

Enable dynamic azure disk volume limits

/sig azure
/kind feature

@andyzhangx

This comment has been minimized.

Show comment
Hide comment
@andyzhangx
Member

andyzhangx commented Aug 23, 2018

@feiskyer feiskyer added this to the v1.12 milestone Aug 24, 2018

@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Aug 27, 2018

Enable dynamic azure disk volume limits
use API to get max disk num

use continue when got exception

add logging

add cache and unit test

fix comments
@andyzhangx

This comment has been minimized.

Show comment
Hide comment
@andyzhangx

andyzhangx Aug 27, 2018

Member

/test pull-kubernetes-e2e-kops-aws

Member

andyzhangx commented Aug 27, 2018

/test pull-kubernetes-e2e-kops-aws

@andyzhangx

This comment has been minimized.

Show comment
Hide comment
@andyzhangx

andyzhangx Aug 27, 2018

Member

/test pull-kubernetes-e2e-kops-aws

Member

andyzhangx commented Aug 27, 2018

/test pull-kubernetes-e2e-kops-aws

@andyzhangx

This comment has been minimized.

Show comment
Hide comment
@andyzhangx

andyzhangx Aug 27, 2018

Member

@feiskyer @gnufied PTAL, thanks.

Member

andyzhangx commented Aug 27, 2018

@feiskyer @gnufied PTAL, thanks.

@feiskyer

This comment has been minimized.

Show comment
Hide comment
@feiskyer

feiskyer Aug 27, 2018

Member

/retest
/lgtm

Member

feiskyer commented Aug 27, 2018

/retest
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 27, 2018

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 27, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Aug 27, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Aug 27, 2018

Contributor

Automatic merge from submit-queue (batch tested with PRs 67766, 67642, 67772). If you want to cherry-pick this change to another branch, please follow the instructions here.

Contributor

k8s-merge-robot commented Aug 27, 2018

Automatic merge from submit-queue (batch tested with PRs 67766, 67642, 67772). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 91e37ee into kubernetes:master Aug 27, 2018

18 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation andyzhangx authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
glog.V(10).Infof("azVirtualMachineSizesClient.List(%q): start", location)
defer func() {
glog.V(10).Infof("azVirtualMachineSizesClient.List(%q): end", location)
}()

This comment has been minimized.

@gnufied

gnufied Aug 27, 2018

Member

Why are we leaving this log message here?

@gnufied

gnufied Aug 27, 2018

Member

Why are we leaving this log message here?

This comment has been minimized.

@andyzhangx

andyzhangx Aug 27, 2018

Member

It's only for debugging, and in normal case on azure, these logs won't be printed since its log level is 10, only log level <=2 messages will be printed.

@andyzhangx

andyzhangx Aug 27, 2018

Member

It's only for debugging, and in normal case on azure, these logs won't be printed since its log level is 10, only log level <=2 messages will be printed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment