New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm - deprecate feature-gates HighAvailability, SelfHosting, CertsInSecrets #67786

Merged
merged 1 commit into from Aug 24, 2018

Conversation

@fabriziopandini
Contributor

fabriziopandini commented Aug 23, 2018

What this PR does / why we need it:
As for sig discussion (see meeting notes - August 22 - 2018) we are going to block usage of feature gates HighAvailability, SelfHosting, CertsInSecrets for new clusters and block updates to v1.12 of existing clusters using such features.

Which issue(s) this PR fixes *(optional, in fixes #<issue number>(, fixes #<issue_number>, ...)
Fixes # kubernetes/kubeadm#1058

Special notes for your reviewer:
I'm going to open issue to track code cleanup in v1.13

Release note:

kubeadm - feature-gates HighAvailability, SelfHosting, CertsInSecrets are now deprecated and can't be used anymore for new clusters. Update of cluster using above feature-gates flag is not supported

/sig cluster-lifecycle
/kind feature
/kind cleanup
/assign @timothysc
/cc

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 23, 2018

Contributor

@fabriziopandini: GitHub didn't allow me to request PR reviews from the following users: fabriziopandini.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What this PR does / why we need it:
As for sig discussion (see meeting notes - August 22 - 2018) we are going to block usage of feature gates HighAvailability, SelfHosting, CertsInSecrets for new clusters and block updates to v1.12 of existing clusters using such features.

Which issue(s) this PR fixes *(optional, in fixes #<issue number>(, fixes #<issue_number>, ...)
Fixes # kubernetes/kubeadm#1058

Special notes for your reviewer:
I'm going to open issue to track code cleanup in v1.13

Release note:

kubeadm - feature-gates HighAvailability, SelfHosting, CertsInSecrets are now deprecated and can't be used anymore for new clusters. Update of cluster using above feature-gates flag is not supported

/sig cluster-lifecycle
/kind feature
/kind cleanup
/assign @timothysc
/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor

k8s-ci-robot commented Aug 23, 2018

@fabriziopandini: GitHub didn't allow me to request PR reviews from the following users: fabriziopandini.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What this PR does / why we need it:
As for sig discussion (see meeting notes - August 22 - 2018) we are going to block usage of feature gates HighAvailability, SelfHosting, CertsInSecrets for new clusters and block updates to v1.12 of existing clusters using such features.

Which issue(s) this PR fixes *(optional, in fixes #<issue number>(, fixes #<issue_number>, ...)
Fixes # kubernetes/kubeadm#1058

Special notes for your reviewer:
I'm going to open issue to track code cleanup in v1.13

Release note:

kubeadm - feature-gates HighAvailability, SelfHosting, CertsInSecrets are now deprecated and can't be used anymore for new clusters. Update of cluster using above feature-gates flag is not supported

/sig cluster-lifecycle
/kind feature
/kind cleanup
/assign @timothysc
/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neolit123

This comment has been minimized.

Show comment
Hide comment
@neolit123

neolit123 Aug 23, 2018

Member

thanks for the PR @fabriziopandini
@kubernetes/sig-cluster-lifecycle-pr-reviews

added a couple of text related comments only.

Member

neolit123 commented Aug 23, 2018

thanks for the PR @fabriziopandini
@kubernetes/sig-cluster-lifecycle-pr-reviews

added a couple of text related comments only.

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 24, 2018

@timothysc

/lgtm
/approve

Thx @fabriziopandini !!

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 24, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Aug 24, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@timothysc

This comment has been minimized.

Show comment
Hide comment
@timothysc

timothysc Aug 24, 2018

Member

/test pull-kubernetes-kubemark-e2e-gce-big

Member

timothysc commented Aug 24, 2018

/test pull-kubernetes-kubemark-e2e-gce-big

@rosti

This comment has been minimized.

Show comment
Hide comment
@rosti

rosti Aug 24, 2018

Contributor

/test pull-kubernetes-kubemark-e2e-gce-big

Contributor

rosti commented Aug 24, 2018

/test pull-kubernetes-kubemark-e2e-gce-big

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Aug 24, 2018

Contributor

Automatic merge from submit-queue (batch tested with PRs 67776, 67503, 67679, 67786, 67830). If you want to cherry-pick this change to another branch, please follow the instructions here.

Contributor

k8s-merge-robot commented Aug 24, 2018

Automatic merge from submit-queue (batch tested with PRs 67776, 67503, 67679, 67786, 67830). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 078961f into kubernetes:master Aug 24, 2018

18 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation fabriziopandini authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@fabriziopandini fabriziopandini deleted the fabriziopandini:kubeadm-deprecate-featureflags branch Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment