-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix apiserver container_env generation in configure-helper.sh #67919
Fix apiserver container_env generation in configure-helper.sh #67919
Conversation
The construction of container_env is broken such that KUBE_CACHE_MUTATION_DETECTOR and ENABLE_PATCH_CONVERSION_DETECTOR are mutually exclusive, due to multiple issues in the construction of the string.
/ok-to-test |
/retest |
2 similar comments
/retest |
/retest |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Katharine If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
`ENABLE_CACHE_MUTATION_DETECTOR` has been set for over a year, but due to a bug in the script parsing it, has not actually run. Fixing the bug such that it can run makes the tests time out. Since an hour is already a long time for presubmit tests, let's not make them longer and instead just stop enabling this. Note that this will have no effect due to a _another_ bug in the default configuration, which sets `ENABLE_CACHE_MUTATION_DETECTOR=false`, which is of course a non-empty string and will cause it to be enabled anyway. See kubernetes/kubernetes#67919 for more context.
`ENABLE_CACHE_MUTATION_DETECTOR` has been set for over a year, but due to a bug in the script parsing it, has not actually run. Fixing the bug such that it can run makes the tests time out. Since an hour is already a long time for presubmit tests, let's not make them longer and instead just stop enabling this. See kubernetes/kubernetes#67919 for more context.
/retest |
1 similar comment
/retest |
/retest I do not understand how this can possibly actually be breaking kops on AWS when it only changes GCE configuration. |
finally passed 😐, raising the flakiness issue to sig-release |
/this-is-fine |
one day I'll write a this-is-fine plugin |
/sig gcp |
/assign vishh |
`ENABLE_CACHE_MUTATION_DETECTOR` has been set for over a year, but due to a bug in the script parsing it, has not actually run. Fixing the bug such that it can run makes the tests time out. Since an hour is already a long time for presubmit tests, let's not make them longer and instead just stop enabling this. See kubernetes/kubernetes#67919 for more context.
`ENABLE_CACHE_MUTATION_DETECTOR` has been set for over a year, but due to a bug in the script parsing it, has not actually run. Fixing the bug such that it can run makes the tests time out. Since an hour is already a long time for presubmit tests, let's not make them longer and instead just stop enabling this. See kubernetes/kubernetes#67919 for more context.
@Katharine: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/this-is-fine |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/meow space |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it: The construction of
container_env
inconfigure-helper.sh
is broken such thatENABLE_CACHE_MUTATION_DETECTOR
andENABLE_PATCH_CONVERSION_DETECTOR
are mutually exclusive, due to multiple issues in the construction of the string.This PR fixes the logic such that the array is correctly constructed, and adds unit tests verifying that it is correct.
Release note: