New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orphan DaemonSet when deleting with --cascade option set #68007

Merged
merged 1 commit into from Sep 4, 2018

Conversation

@soltysh
Contributor

soltysh commented Aug 29, 2018

What this PR does / why we need it:
This is a followup to #64847 to ensure that --cascade options is properly handled for DaemonSet

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
This was originally described in https://bugzilla.redhat.com/show_bug.cgi?id=1623352

For review:
/assign @mfojtik
For 1.11 approval:
/assign @foxish

cc @janetkuo

Release note:

Orphan DaemonSet when deleting with --cascade option set
@mfojtik

This comment has been minimized.

Show comment
Hide comment
@mfojtik

mfojtik Aug 29, 2018

Contributor

/lgtm

Contributor

mfojtik commented Aug 29, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 29, 2018

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 29, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Aug 29, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh

This comment has been minimized.

Show comment
Hide comment
@soltysh

soltysh Aug 29, 2018

Contributor

/retest

Contributor

soltysh commented Aug 29, 2018

/retest

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 30, 2018

Contributor

New changes are detected. LGTM label has been removed.

Contributor

k8s-ci-robot commented Aug 30, 2018

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 30, 2018

@soltysh

This comment has been minimized.

Show comment
Hide comment
@soltysh

soltysh Aug 30, 2018

Contributor

Fixed the error @tnozicka pointed out.

/hold cancel

Contributor

soltysh commented Aug 30, 2018

Fixed the error @tnozicka pointed out.

/hold cancel

@soltysh

This comment has been minimized.

Show comment
Hide comment
@soltysh

soltysh Aug 30, 2018

Contributor

Re-applying the lgtm label back.

Contributor

soltysh commented Aug 30, 2018

Re-applying the lgtm label back.

@soltysh soltysh added the lgtm label Aug 30, 2018

@soltysh

This comment has been minimized.

Show comment
Hide comment
@soltysh

soltysh Aug 30, 2018

Contributor

/retest

Contributor

soltysh commented Aug 30, 2018

/retest

@soltysh

This comment has been minimized.

Show comment
Hide comment
@soltysh

soltysh Sep 4, 2018

Contributor

@foxish for the 1.11 approval

Contributor

soltysh commented Sep 4, 2018

@foxish for the 1.11 approval

@foxish foxish added this to the v1.11 milestone Sep 4, 2018

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Sep 4, 2018

Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

Contributor

k8s-merge-robot commented Sep 4, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Sep 4, 2018

Contributor

Automatic merge from submit-queue.

Contributor

k8s-merge-robot commented Sep 4, 2018

Automatic merge from submit-queue.

@k8s-merge-robot k8s-merge-robot merged commit 65a072d into kubernetes:release-1.11 Sep 4, 2018

17 of 18 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-kubemark-e2e-gce-big
Details
cla/linuxfoundation soltysh authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Skipped
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@soltysh soltysh deleted the soltysh:bug1623352 branch Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment