Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start deprecating all generators in run except for run-pod/v1 #68132

Merged
merged 1 commit into from Sep 4, 2018

Conversation

@soltysh
Copy link
Contributor

commented Aug 31, 2018

What this PR does / why we need it:
This was discussed during SIG-CLI meetings over several past months. The direction is that we want to move away from kubectl run because it's over bloated and complicated for both users and developers. We want to mimic docker run with kubectl run so that it only creates a pod, and if you're interested in other resources kubectl create is the intended replacement.

This PR starts with deprecating all of the generator except for the pod one.

/assign @juanvallejo
/sig cli
/milestone v1.12

Release note:

Deprecate kubectl run generators, except for run-pod/v1

@soltysh soltysh force-pushed the soltysh:deprecate_run branch from e15b1db to 2c4917d Sep 4, 2018

@k8s-ci-robot k8s-ci-robot added size/XS and removed size/S labels Sep 4, 2018

@juanvallejo

This comment has been minimized.

Copy link
Member

commented Sep 4, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 4, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanvallejo, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2018

Automatic merge from submit-queue (batch tested with PRs 63011, 68089, 67944, 68132). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

@k8s-github-robot k8s-github-robot merged commit 92ad24c into kubernetes:master Sep 4, 2018

18 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation soltysh authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@soltysh soltysh deleted the soltysh:deprecate_run branch Sep 6, 2018

@brendandburns

This comment has been minimized.

Copy link
Contributor

commented Oct 20, 2018

@soltysh can we get some clarification here, it seems that 'kubectl run ' will remain, but the deprecation warning for 'kubectl run' seems to indicate that it's all going to be deprecated.

I think that this is because the default for kubectl run is Deployment based, not run-pod, but I think that is leading to some confusion (e.g. https://stackoverflow.com/questions/52890718/kubectl-run-is-deprecated-looking-for-alternative)

I think we should make it clear that a user can run:

kubectl run --generator=run-pod/v1 ... to get the behavior they likely want rather than looking for a new command.

@soltysh

This comment has been minimized.

Copy link
Contributor Author

commented Oct 26, 2018

@brendandburns the main gist is, we want the kubectl run to mimic docker run in k8s world. For creating resources we already have a bunch of kubectl create sub-commands. Additionally, the vast majority of different options and their influence on the actual resource produces by kubectl run is another reason we're going into simple and straightforward direction. I've replied in the SO thread. I'll also post that on my personal twitter, appreciate retweets for greater audience.

@soltysh

This comment has been minimized.

Copy link
Contributor Author

commented Oct 26, 2018

I've also opened #70288 to improve the deprecation warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.