Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update etcd client to 3.2.24 for latest release #68147

Merged
merged 1 commit into from Sep 5, 2018

Conversation

@timothysc
Copy link
Member

timothysc commented Aug 31, 2018

What this PR does / why we need it:
Updates etcd client to 3.2.24 which is the latest in the 3.2 series. See https://github.com/etcd-io/etcd/blob/master/CHANGELOG-3.2.md for details.

Special notes for your reviewer:
This is only the client, in order to update the server components it requires a googler to push the 3.2.24 image.

Release note:

Update etcd client interface to 3.2.24

/assign @jpbetz @wojtek-t
/cc @liggitt @kubernetes/sig-cluster-lifecycle @kubernetes/sig-scalability-pr-reviews

@timothysc

This comment has been minimized.

Copy link
Member Author

timothysc commented Aug 31, 2018

/assign @gyuho

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Aug 31, 2018

@timothysc: GitHub didn't allow me to assign the following users: gyuho.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @gyuho

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timothysc

This comment has been minimized.

Copy link
Member Author

timothysc commented Aug 31, 2018

/retest

@gyuho

This comment has been minimized.

Copy link
Member

gyuho commented Aug 31, 2018

@timothysc @jpbetz

From v3.2.13 to v3.2.24.

Most changes were made in server-side.

Client-side changes are:

  • Introduce ErrLeaseTTLTooLarge for too large TTL input from client (max TTL is 9000000000)
  • Improve TLS handshake client-side logging
  • Add back-off logic to watch retries etcd-io/etcd#9840 @liggitt
  • Fix lease keepalive interval updates when response queue is full etcd-io/etcd#9952
@timothysc

This comment has been minimized.

Copy link
Member Author

timothysc commented Aug 31, 2018

@gyuho thx.

Only a googler can push the server side changes so I'm blocked on that.

@dims

This comment has been minimized.

Copy link
Member

dims commented Aug 31, 2018

cc @ixdy

@timothysc

This comment has been minimized.

Copy link
Member Author

timothysc commented Sep 1, 2018

/cc @kubernetes/sig-release-pr-reviews

@dixudx

This comment has been minimized.

Copy link
Member

dixudx commented Sep 1, 2018

@timothysc this looks good to me.

Please rebase it. Thanks for the work. 👍

@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Sep 3, 2018

/approve

@timothysc - please rebase

@jpbetz

This comment has been minimized.

Copy link
Contributor

jpbetz commented Sep 4, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 4, 2018

@timothysc

This comment has been minimized.

Copy link
Member Author

timothysc commented Sep 4, 2018

I'm not going to be able to finish this until this evening due to other restrictions.
This particular change is more of a bug fix and low risk.

Update etcd client to 3.2.24 for latest release
Signed-off-by: Timothy St. Clair <timothysc@gmail.com>

@timothysc timothysc force-pushed the timothysc:etcd-3.2-latest branch from de0f624 to 0bb21f6 Sep 5, 2018

@timothysc

This comment has been minimized.

Copy link
Member Author

timothysc commented Sep 5, 2018

@wojtek-t PTAL, I'll check back in the morning.

@xiangpengzhao

This comment has been minimized.

Copy link
Member

xiangpengzhao commented Sep 5, 2018

BTW, do we want to use the new path github.com/etcd-io/etcd for import or still use github.com/coreos/etcd and let it be redirected?

@gyuho

This comment has been minimized.

Copy link
Member

gyuho commented Sep 5, 2018

@xiangpengzhao We still use old import paths for release branches.

@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Sep 5, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 5, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Sep 5, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, timothysc, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Sep 5, 2018

Automatic merge from submit-queue (batch tested with PRs 67691, 68147). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

@k8s-github-robot k8s-github-robot merged commit 2811228 into kubernetes:master Sep 5, 2018

18 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation timothysc authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

k8s-github-robot pushed a commit that referenced this pull request Sep 7, 2018

Kubernetes Submit Queue
Merge pull request #68318 from timothysc/etcd-3-2-24
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

Update default etcd server to 3.2.24 for kubernetes 1.12

**What this PR does / why we need it**:
Update default etcd server to 3.2.24 for kubernetes 1.12

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
xref #68147 

**Special notes for your reviewer**:
NONE

**Release note**:

```
Update default etcd server to 3.2.24 for kubernetes 1.12
```

/assign @wojtek-t @jpbetz @dims 
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews @gyuho
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.