Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use informer cache instead of active pod gets in HPA controller. #68241

Merged
merged 1 commit into from Sep 8, 2018

Conversation

@krzysztof-jastrzebski
Copy link
Contributor

commented Sep 4, 2018

What this PR does / why we need it:
Use informer cache instead of active pod gets in HPA controller.

Which issue(s) this PR fixes:
Fixes #68217

Release note:

kube-controller-manager: use informer cache instead of active pod gets in HPA controller
@krzysztof-jastrzebski

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2018

/assign mwielgus
/assign @DirectXMan12

@mwielgus

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2018

/ok-to-test

@mwielgus mwielgus added this to the v1.12 milestone Sep 4, 2018

@neolit123

This comment has been minimized.

Copy link
Member

commented Sep 5, 2018

@krzysztof-jastrzebski
please add this as a release note:

kube-controller-manager: use informer cache instead of active pod gets in HPA controller

also the PR needs a rebase. :)

@krzysztof-jastrzebski krzysztof-jastrzebski force-pushed the krzysztof-jastrzebski:informer branch from a47d32c to 6f06f72 Sep 5, 2018

@krzysztof-jastrzebski krzysztof-jastrzebski force-pushed the krzysztof-jastrzebski:informer branch from 6f06f72 to 57a7394 Sep 5, 2018

@krzysztof-jastrzebski krzysztof-jastrzebski force-pushed the krzysztof-jastrzebski:informer branch from 57a7394 to 985ba93 Sep 5, 2018

@DirectXMan12

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 5, 2018

@mwielgus

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2018

/approve

1 similar comment
@wojtek-t

This comment has been minimized.

Copy link
Member

commented Sep 6, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, krzysztof-jastrzebski, mwielgus, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fedebongio

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2018

/assign @jpbetz

@dims

This comment has been minimized.

Copy link
Member

commented Sep 8, 2018

/priority critical-urgent

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 8, 2018

Automatic merge from submit-queue (batch tested with PRs 65250, 68241). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

@k8s-github-robot k8s-github-robot merged commit 9e9c414 into kubernetes:master Sep 8, 2018

18 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation krzysztof-jastrzebski authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.