New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump addon-manager to v8.7 #68299

Merged
merged 1 commit into from Sep 6, 2018

Conversation

@MrHohn
Member

MrHohn commented Sep 5, 2018

What this PR does / why we need it:
Major changes:

  • Support extra --prune-whitelist resources in kube-addon-manager.
  • Update kubectl to v1.10.7.

Basically picking up #67743.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #NONE

Special notes for your reviewer:
/assign @Random-Liu @mikedanese

Release note:

Bump addon-manager to v8.7
- Support extra `--prune-whitelist` resources in kube-addon-manager.
- Update kubectl to v1.10.7.
Bump addon-manager to v8.7
- Support extra `--prune-whitelist` resources in kube-addon-manager.
- Update kubectl to v1.10.7.
@Random-Liu

This comment has been minimized.

Show comment
Hide comment
@Random-Liu

Random-Liu Sep 5, 2018

Member

/lgtm

Member

Random-Liu commented Sep 5, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 5, 2018

@Random-Liu Random-Liu added this to the v1.12 milestone Sep 6, 2018

@Random-Liu

This comment has been minimized.

Show comment
Hide comment
@Random-Liu

Random-Liu Sep 6, 2018

Member

ping @mikedanese for approval. :)

Member

Random-Liu commented Sep 6, 2018

ping @mikedanese for approval. :)

@mikedanese

This comment has been minimized.

Show comment
Hide comment
@mikedanese

mikedanese Sep 6, 2018

Member

/approve

Member

mikedanese commented Sep 6, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Sep 6, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikedanese, MrHohn, Random-Liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Sep 6, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikedanese, MrHohn, Random-Liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

VERSION=v8.6
KUBECTL_VERSION?=v1.9.3
VERSION=v8.7
KUBECTL_VERSION?=v1.10.7

This comment has been minimized.

@mikedanese

mikedanese Sep 6, 2018

Member

why not 1.11?

@mikedanese

mikedanese Sep 6, 2018

Member

why not 1.11?

This comment has been minimized.

@MrHohn

MrHohn Sep 6, 2018

Member

Just in case we would need to cherrypick this to 1.10.

@MrHohn

MrHohn Sep 6, 2018

Member

Just in case we would need to cherrypick this to 1.10.

@MrHohn

This comment has been minimized.

Show comment
Hide comment
@MrHohn

MrHohn Sep 6, 2018

Member

/priority critical-urgent

Member

MrHohn commented Sep 6, 2018

/priority critical-urgent

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Sep 6, 2018

Contributor

Automatic merge from submit-queue (batch tested with PRs 68087, 68256, 64621, 68299, 68296). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

Contributor

k8s-merge-robot commented Sep 6, 2018

Automatic merge from submit-queue (batch tested with PRs 68087, 68256, 64621, 68299, 68296). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

@k8s-merge-robot k8s-merge-robot merged commit 3811360 into kubernetes:master Sep 6, 2018

18 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation MrHohn authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

k8s-ci-robot added a commit that referenced this pull request Sep 18, 2018

Merge pull request #68489 from Random-Liu/automated-cherry-pick-of-#6…
…8299-upstream-release-1.11

Automated cherry pick of #68299: Bump addon-manager to v8.7 - Support extra
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment