New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default etcd server to 3.2.24 for kubernetes 1.12 #68318

Merged
merged 1 commit into from Sep 7, 2018

Conversation

@timothysc
Member

timothysc commented Sep 6, 2018

What this PR does / why we need it:
Update default etcd server to 3.2.24 for kubernetes 1.12

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #68147

Special notes for your reviewer:
NONE

Release note:

Update default etcd server to 3.2.24 for kubernetes 1.12

/assign @wojtek-t @jpbetz @dims
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews @gyuho

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Sep 6, 2018

Contributor

@timothysc: GitHub didn't allow me to request PR reviews from the following users: gyuho.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What this PR does / why we need it:
Update default etcd server to 3.2.24 for kubernetes 1.12

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #68147

Special notes for your reviewer:
NONE

Release note:

Update default etcd server to 3.2.24 for kubernetes 1.12

/assign @wojtek-t @jpbetz @dims
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews @gyuho

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor

k8s-ci-robot commented Sep 6, 2018

@timothysc: GitHub didn't allow me to request PR reviews from the following users: gyuho.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What this PR does / why we need it:
Update default etcd server to 3.2.24 for kubernetes 1.12

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #68147

Special notes for your reviewer:
NONE

Release note:

Update default etcd server to 3.2.24 for kubernetes 1.12

/assign @wojtek-t @jpbetz @dims
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews @gyuho

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timothysc

This comment has been minimized.

Show comment
Hide comment
@timothysc
Member

timothysc commented Sep 6, 2018

/cc @liggitt

@k8s-ci-robot k8s-ci-robot requested a review from liggitt Sep 6, 2018

@@ -63,7 +63,7 @@ func etcdUpgradeGCE(target_storage, target_version string) error {
os.Environ(),
"TEST_ETCD_VERSION="+target_version,
"STORAGE_BACKEND="+target_storage,
"TEST_ETCD_IMAGE=3.2.18-0")
"TEST_ETCD_IMAGE=3.2.24-0")

This comment has been minimized.

@wojtek-t

wojtek-t Sep 6, 2018

Member

Please also modify test/kubemark/start-kubemark.sh

@wojtek-t

wojtek-t Sep 6, 2018

Member

Please also modify test/kubemark/start-kubemark.sh

This comment has been minimized.

@timothysc

timothysc Sep 6, 2018

Member

Done, plus I found one other test that needed an update too.

@timothysc

timothysc Sep 6, 2018

Member

Done, plus I found one other test that needed an update too.

@luxas

luxas approved these changes Sep 6, 2018

LGTM

@dims

This comment has been minimized.

Show comment
Hide comment
@dims

dims Sep 6, 2018

Member

i cross checked the changes in this PR with what i had from earlier and it looks good except for the one spot that @wojtek-t mentioned already in test/kubemark/start-kubemark.sh

# Etcd related variables.
ETCD_IMAGE="${ETCD_IMAGE:-3.2.18-0}"
ETCD_VERSION="${ETCD_VERSION:-}"
Member

dims commented Sep 6, 2018

i cross checked the changes in this PR with what i had from earlier and it looks good except for the one spot that @wojtek-t mentioned already in test/kubemark/start-kubemark.sh

# Etcd related variables.
ETCD_IMAGE="${ETCD_IMAGE:-3.2.18-0}"
ETCD_VERSION="${ETCD_VERSION:-}"
@timothysc

This comment has been minimized.

Show comment
Hide comment
@timothysc
Member

timothysc commented Sep 6, 2018

@wojtek-t PTAL.

@wojtek-t

This comment has been minimized.

Show comment
Hide comment
@wojtek-t

wojtek-t Sep 6, 2018

Member

/lgtm

Member

wojtek-t commented Sep 6, 2018

/lgtm

@dims

This comment has been minimized.

Show comment
Hide comment
@dims

dims Sep 6, 2018

Member

+1 from me

Member

dims commented Sep 6, 2018

+1 from me

Update default etcd server to 3.2.24 for kubernetes 1.12
Signed-off-by: Timothy St. Clair <timothysc@gmail.com>

@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 6, 2018

@timothysc

This comment has been minimized.

Show comment
Hide comment
@timothysc

timothysc Sep 6, 2018

Member

/test pull-kubernetes-e2e-gke
/test pull-kubernetes-verify
/test pull-kubernetes-e2e-kops-aws

Member

timothysc commented Sep 6, 2018

/test pull-kubernetes-e2e-gke
/test pull-kubernetes-verify
/test pull-kubernetes-e2e-kops-aws

@sttts

This comment has been minimized.

Show comment
Hide comment
@sttts

sttts Sep 7, 2018

Contributor

/lgtm

Contributor

sttts commented Sep 7, 2018

/lgtm

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Sep 7, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts, timothysc, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Sep 7, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts, timothysc, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Sep 7, 2018

Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

Contributor

k8s-merge-robot commented Sep 7, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Sep 7, 2018

Contributor

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

Contributor

k8s-merge-robot commented Sep 7, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

@k8s-merge-robot k8s-merge-robot merged commit 3617462 into kubernetes:master Sep 7, 2018

17 of 18 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
cla/linuxfoundation timothysc authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment