New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cAdvisor godeps to v0.31.0 #68431

Merged
merged 1 commit into from Sep 12, 2018

Conversation

@dashpole
Contributor

dashpole commented Sep 8, 2018

What this PR does / why we need it:
Update the cAdvisor dependency for the 1.12 release.

Special notes for your reviewer:
Some of the interfaces of cAdvisor changed this release. The values used here maintain the previous behavior.

This PR adds a few new new vendored dependencies that were added as part of adding mesos containerizer support. All new dependencies have Apache 2.0 licenses.

Release note:

- cAdvisor: Fix NVML initialization race condition
- cAdvisor: Fix brtfs filesystem discovery
- cAdvisor: Fix race condition with AllDockerContainers
- cAdvisor: Don't watch .mount cgroups
- cAdvisor: Reduce lock contention during list containers

/assign @dchen1107 @thockin

@dashpole

This comment has been minimized.

Show comment
Hide comment
@dashpole

dashpole Sep 8, 2018

Contributor

/sig node
/priority critical-urgent
/kind bug

Contributor

dashpole commented Sep 8, 2018

/sig node
/priority critical-urgent
/kind bug

@dashpole

This comment has been minimized.

Show comment
Hide comment
@dashpole

dashpole Sep 8, 2018

Contributor

apologies for letting this slip so late. Thanks to @bboreham for reminding us.

Contributor

dashpole commented Sep 8, 2018

apologies for letting this slip so late. Thanks to @bboreham for reminding us.

@k8s-ci-robot k8s-ci-robot requested review from dchen1107 and resouer Sep 8, 2018

@dchen1107

This comment has been minimized.

Show comment
Hide comment
@dchen1107

dchen1107 Sep 8, 2018

Member

/retest

Member

dchen1107 commented Sep 8, 2018

/retest

@dchen1107

This comment has been minimized.

Show comment
Hide comment
@dchen1107

dchen1107 Sep 8, 2018

Member

cc/ @derekwaynecarr

/approve

Member

dchen1107 commented Sep 8, 2018

cc/ @derekwaynecarr

/approve

@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Sep 10, 2018

@dashpole

This comment has been minimized.

Show comment
Hide comment
@dashpole

dashpole Sep 10, 2018

Contributor

/retest

Contributor

dashpole commented Sep 10, 2018

/retest

@thockin

This comment has been minimized.

Show comment
Hide comment
@thockin

thockin Sep 10, 2018

Member

/lgtm
/approve

Member

thockin commented Sep 10, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 10, 2018

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Sep 10, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, dchen1107, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Sep 10, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, dchen1107, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mtaufen mtaufen added this to the v1.12 milestone Sep 11, 2018

@k8s-ci-robot k8s-ci-robot merged commit 37ef6ee into kubernetes:master Sep 12, 2018

19 checks passed

Submit Queue Context retired. Status moved to "tide".
cla/linuxfoundation dashpole authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment