Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
add shellcheck lint #68438
What this PR does / why we need it: Adds a
Which issue(s) this PR fixes (optional, in
Special notes for your reviewer:
referenced this pull request
Sep 8, 2018
On Sat, Sep 8, 2018, 17:23 k8s-ci-robot ***@***.***> wrote: @BenTheElder <https://github.com/BenTheElder>: The following tests *failed*, say /retest to rerun them all: Test name Commit Details Rerun command pull-kubernetes-verify 8edced6 <8edced6> link <https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/68438/pull-kubernetes-verify/106179/> /test pull-kubernetes-verify pull-kubernetes-integration c21b6e9 <c21b6e9> link <https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/68438/pull-kubernetes-integration/27162/> /test pull-kubernetes-integration Full PR test history <https://k8s-gubernator.appspot.com/pr/68438>. Your PR dashboard <https://k8s-gubernator.appspot.com/pr/BenTheElder>. Please help us cut down on flakes by linking to <https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests> an open issue <https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when you hit one in your PR. Instructions for interacting with me using PR comments are available here <https://git.k8s.io/community/contributors/guide/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. I understand the commands that are listed here <https://go.k8s.io/bot-commands>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#68438 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA4Bq9Qs4KKtm1PWy3M5kzeFHZ0Zsgvoks5uZF9rgaJpZM4WgD5N> .
Suggestion : this is GPLv3 code in https://github.com/koalaman/shellcheck and looks like it's good news that they have published container images https://hub.docker.com/r/koalaman/shellcheck/tags/ - can we please use those?
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing