New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable proxy use in http probe #68663

Merged
merged 1 commit into from Dec 4, 2018

Conversation

@WanLinghao
Copy link
Contributor

WanLinghao commented Sep 14, 2018

Disable node's proxy use of http probe

disable node's proxy use of http probe

@WanLinghao WanLinghao force-pushed the WanLinghao:probe_proxy branch from d1f5146 to 85cf0ec Sep 14, 2018

@WanLinghao WanLinghao force-pushed the WanLinghao:probe_proxy branch from 85cf0ec to a12b7dc Sep 14, 2018

@WanLinghao WanLinghao force-pushed the WanLinghao:probe_proxy branch from a12b7dc to 1eefe29 Sep 16, 2018

@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Sep 18, 2018

@WanLinghao WanLinghao force-pushed the WanLinghao:probe_proxy branch from e0fd795 to 22fff42 Sep 19, 2018

@WanLinghao WanLinghao force-pushed the WanLinghao:probe_proxy branch from 11eb8dd to edaa472 Sep 27, 2018

@k8s-ci-robot k8s-ci-robot added size/XS and removed size/L labels Sep 27, 2018

@WanLinghao WanLinghao force-pushed the WanLinghao:probe_proxy branch from edaa472 to 0c323fe Sep 27, 2018

@WanLinghao WanLinghao changed the title Add proxy disable support to http probe Disable proxy use in http probe Sep 27, 2018

@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels Oct 9, 2018

@WanLinghao WanLinghao force-pushed the WanLinghao:probe_proxy branch 2 times, most recently from bea838f to 5d073df Oct 9, 2018

@WanLinghao WanLinghao referenced this pull request Nov 8, 2018

Closed

k8s 健康监测bug #70721

@WanLinghao WanLinghao force-pushed the WanLinghao:probe_proxy branch from 5d073df to 1128fa4 Nov 29, 2018

@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Nov 29, 2018

@WanLinghao WanLinghao force-pushed the WanLinghao:probe_proxy branch from 1128fa4 to b8dbbff Nov 29, 2018

@WanLinghao WanLinghao changed the title [WIP]Disable proxy use in http probe Disable proxy use in http probe Nov 29, 2018

@WanLinghao

This comment has been minimized.

Copy link
Contributor

WanLinghao commented Nov 29, 2018

@smarterclayton Now unit test added, PTAL

When node got proxy settings like "http_proxy=xxx".
The http probe would use that settings. This could cause probe failure.
This patch fix it.

@WanLinghao WanLinghao force-pushed the WanLinghao:probe_proxy branch from b8dbbff to 29f7e53 Nov 29, 2018

@WanLinghao

This comment has been minimized.

Copy link
Contributor

WanLinghao commented Nov 29, 2018

/test pull-kubernetes-kubemark-e2e-gce-big

@juanvallejo

This comment has been minimized.

Copy link
Member

juanvallejo commented Dec 3, 2018

lgtm

@soltysh

soltysh approved these changes Dec 3, 2018

Copy link
Contributor

soltysh left a comment

/lgtm

@soltysh

This comment has been minimized.

Copy link
Contributor

soltysh commented Dec 3, 2018

@smarterclayton for approval

@smarterclayton

This comment has been minimized.

Copy link
Contributor

smarterclayton commented Dec 4, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 4, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, WanLinghao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8ffc8ef into kubernetes:master Dec 4, 2018

18 checks passed

cla/linuxfoundation WanLinghao authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment