Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Make SSH path handling consistent across providers during e2e #68753
There were providers which would:
This change makes it such that each of the supported providers
What this PR does / why we need it:
Special notes for your reviewer:
It looks like the notable breaking changes are that
I'm not sure who sets these variables, but that might be problematic. Maybe use
There were providers which would: - allow overrides of the file base name but not the path - allow oeverrides of the file path - not allow any overrides at all This change makes it such that each of the supported providers can override the SSH key location using an env var. The env var itself may vary based on the provider though. If given an absolute path to the key, it is used. If given a relative path it will be made relative to ~/.ssh Fixes: #68747
@ixdy You're right, that logic wasn't awkward to accommodate and actually made it more versatile. Now each provider can support relative or absolute paths and, assuming the users env vars were properly set in the past, then this should still work.
Release notes were updated to specify the exact changes for reach of the providers affected. In every case it was extending existing functionality and now makes them all consistent.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
2 similar comments